schedv2 - correct description of _getCard#2
Open
ijgnd wants to merge 567 commits intoArthur-Milchior:forkfrom
ijgnd:patch-2
Open
schedv2 - correct description of _getCard#2ijgnd wants to merge 567 commits intoArthur-Milchior:forkfrom ijgnd:patch-2
ijgnd wants to merge 567 commits intoArthur-Milchior:forkfrom
ijgnd:patch-2
Conversation
Add a «column» menu in browser
This allow to avoid having to show advanced column when this add-on is not installed.
# Conflicts: # anki/incorporatedAddons.py
# Conflicts: # anki/incorporatedAddons.py
# Conflicts: # anki/incorporatedAddons.py # aqt/preferences.py # designer/preferences.ui
# Conflicts: # anki/incorporatedAddons.py # aqt/browser.py # aqt/preferences.py # designer/browser.ui
# Conflicts: # anki/incorporatedAddons.py # aqt/preferences.py # designer/preferences.ui
# Conflicts: # anki/incorporatedAddons.py # aqt/preferences.py # designer/preferences.ui # difference.md
# Conflicts: # anki/incorporatedAddons.py
# Conflicts: # anki/incorporatedAddons.py # difference.md
# Conflicts: # anki/incorporatedAddons.py # anki/model.py # difference.md
# Conflicts: # anki/cards.py # anki/collection.py # anki/fields.py # anki/incorporatedAddons.py # anki/model.py # aqt/preferences.py # designer/preferences.ui # difference.md
The point here is: * add-ons can use them * we don't have them in the code base when creating branches
Owner
|
Thank you. I'll correct that. Not in this commit however, for technical reasons |
Arthur-Milchior
force-pushed
the
fork
branch
2 times, most recently
from
103b68b to
6e2295e
Compare
Arthur-Milchior
force-pushed
the
fork
branch
4 times, most recently
from
653ad02 to
c72025b
Compare
Arthur-Milchior
force-pushed
the
fork
branch
3 times, most recently
from
aa8c88a to
7376669
Compare
Arthur-Milchior
force-pushed
the
fork
branch
3 times, most recently
from
602871b to
446cde4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor update.
Thanks for the great documentation.
The same problem also affects the description of the function in v1 - https://github.com/Arthur-Milchior/anki/blob/fork/anki/sched.py#L130
I think from the github web interface I can't make a change to two files in one commit.