Skip to content

fix: checkout release tag in publish workflows#19

Merged
Arthurdw merged 1 commit intomainfrom
fix/publish-workflow-checkout-ref
Jan 31, 2026
Merged

fix: checkout release tag in publish workflows#19
Arthurdw merged 1 commit intomainfrom
fix/publish-workflow-checkout-ref

Conversation

@Arthurdw
Copy link
Owner

@Arthurdw Arthurdw commented Jan 31, 2026

Summary

Fixes publish workflows checking out the wrong commit, causing "version already exists" errors.

Problem

When release-pilot runs, it:

  1. Bumps versions in files
  2. Commits and pushes to main
  3. Creates a tag

But the downstream publish workflows (vscode-publish.yml, jetbrains-publish.yml) were checking out the original commit SHA that triggered the workflow, not the new version-bumped commit. This caused the VSCode publish to fail with:

arthurdw.rovo-lsp v0.3.1 already exists.

Solution

  • Add ref input to both publish workflows
  • Pass the release tag from release-pilot output to publish workflows
  • Checkout the tagged commit to ensure the correct version is published

Changes

File Change
weekly_release.yml Output tag from release job, pass to publish workflows
vscode-publish.yml Add ref input, checkout specified ref
jetbrains-publish.yml Add ref input, checkout specified ref

Summary by CodeRabbit

  • Chores
    • Enhanced GitHub Actions workflow configuration to improve coordination between release generation and platform-specific publishing processes. Enables more flexible management of release versions and deployment parameters across distribution channels, providing better control and visibility over artifact distribution to the VSCode extension marketplace and JetBrains plugin repository.

✏️ Tip: You can customize this high-level summary in your review settings.

Publish workflows were checking out the original commit SHA instead of
the new version-bumped commit created by release-pilot. This caused
VSCode publish to fail with 'version already exists' because it was
building the old version.

- Add 'ref' input to vscode-publish.yml and jetbrains-publish.yml
- Pass release tag from release-pilot to publish workflows
- Checkout the tagged commit to ensure correct version is published
@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

GitHub Actions workflows are enhanced to support parameterized git references. The jetbrains-publish and vscode-publish workflows now accept an optional ref input parameter, while weekly_release exports the release tag and passes it to these workflows during publishing.

Changes

Cohort / File(s) Summary
Publish Workflows
.github/workflows/jetbrains-publish.yml, .github/workflows/vscode-publish.yml
Add optional ref input parameter to workflow_call. Update checkout step to use provided ref or fallback to github.ref, enabling external callers to specify which git reference to check out.
Release Workflow
.github/workflows/weekly_release.yml
Add tag output from Release job. Wire the release tag to both publish workflow invocations via ref: ${{ needs.release.outputs.tag }} parameter.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

CI/CD, release:patch

Poem

🐰 Hop-hop, the workflows now take flight,
With ref parameters shining bright,
Release tags pass from job to job,
A pipeline dance—no need to throb!
The bunny's pipelines now align,
Each checkout picks the perfect line.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: adding ref checkout capability to publish workflows to fix version-bumped release tag handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/publish-workflow-checkout-ref

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Arthurdw Arthurdw self-assigned this Jan 31, 2026
@Arthurdw Arthurdw added the CI/CD label Jan 31, 2026
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.42%. Comparing base (d004538) to head (66d5975).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          17       17           
  Lines        5462     5462           
=======================================
  Hits         5048     5048           
  Misses        414      414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Arthurdw Arthurdw merged commit 4a5a140 into main Jan 31, 2026
10 checks passed
@Arthurdw Arthurdw deleted the fix/publish-workflow-checkout-ref branch January 31, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant