Conversation
📝 WalkthroughWalkthroughThe changes add Open VSX Registry publishing support to the extension's CI/CD pipeline. A new workflow secret authenticates publication, and a dedicated step publishes the extension using the ovsx CLI tool to reach VSCode fork users. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/vscode-publish.yml (1)
50-52: Optional: reuse the already-packaged.vsixinstead of re-packaging.
ovsx publishwithout a file argument packages the extension in the current working directory using vsce and then publishes it, duplicating the work already done bynpm run package.ovsx publish <file>publishes an already packaged file, so you can skip the second packaging pass.♻️ Proposed refactor
- run: npx ovsx publish + run: npx ovsx publish *.vsix🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/vscode-publish.yml around lines 50 - 52, The publish step named "Publish to Open VSX Registry" currently runs "npx ovsx publish -p ${{ secrets.OVSX_PAT }}" which repackages the extension; change it to publish the already-created .vsix instead by pointing ovsx to the packaged file (the .vsix produced by your earlier "npm run package" step). Update the step's run command to call ovsx publish with the .vsix filename or glob (e.g., the artifact name produced by your packaging step) so it skips re-packaging and uses the existing .vsix; ensure the file path or glob matches the output from the earlier packaging step.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/vscode-publish.yml:
- Around line 50-52: The "Publish to Open VSX Registry" step currently
interpolates the secret into the run line; change the step to set the secret via
an env block (ENV name OVSX_PAT) and remove the -p flag so ovsx reads the token
from the environment automatically; keep the step name and working-directory
(vscode-rovo) the same and update the run to just "npx ovsx publish" to avoid
embedding the secret in the shell command.
In `@vscode-rovo/package.json`:
- Line 105: The package.json contains an invalid ovsx version ("ovsx":
"^0.10.9") that doesn't exist on npm; update the dependency entry for "ovsx" to
a published version (for example "^0.10.5" or "0.10.5") so the semver range is
satisfiable and CI installs succeed—edit the "ovsx" line in package.json
accordingly and run npm install to verify.
---
Nitpick comments:
In @.github/workflows/vscode-publish.yml:
- Around line 50-52: The publish step named "Publish to Open VSX Registry"
currently runs "npx ovsx publish -p ${{ secrets.OVSX_PAT }}" which repackages
the extension; change it to publish the already-created .vsix instead by
pointing ovsx to the packaged file (the .vsix produced by your earlier "npm run
package" step). Update the step's run command to call ovsx publish with the
.vsix filename or glob (e.g., the artifact name produced by your packaging step)
so it skips re-packaging and uses the existing .vsix; ensure the file path or
glob matches the output from the earlier packaging step.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 17 17
Lines 5462 5462
=======================================
Hits 5048 5048
Misses 414 414 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #21
This was easier to implement than I thought :)
Also updated the deps lockfiles so that thats up to date aswell, will do a patch release for this.
Summary by CodeRabbit