All fixed#2
Merged
ArtyomGaribyan merged 3 commits intomainfrom Jan 9, 2026
Merged
Conversation
ivannizh
reviewed
Nov 23, 2025
ivannizh
left a comment
ivannizh
left a comment
There was a problem hiding this comment.
- Плохо, что не продолжил работать в той же ветке, в том же пуллреквесте.
- По коду все ок, его готов принять
- НО! Тесты не проходят
go test ./tests/ -count=1
| log.Println(task.Error) | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| writeJson(w, task) | ||
| if err != nil && err.Error() != "EOF" { |
There was a problem hiding this comment.
Если ошибка, значит структуру нельзя использовать, а у тебя получается при ошибке EOF структура считается "чистой"
ivannizh
approved these changes
Nov 24, 2025
ivannizh
left a comment
ivannizh
left a comment
There was a problem hiding this comment.
Артем, привет!
Хорошая выпускная работа, всё работает, тесты проходят.
Код хорошо написан и верно разложен по файлам!
Работу принимаю!
Поздравляю с окончанием курса и желаю успехов в дальнейшем освоении Go!
| GetTaskHandler(w, task.ID) | ||
| case http.MethodPost: | ||
| addTaskHandler(w, task) | ||
| getTaskBody(w, r, &task) |
There was a problem hiding this comment.
Было хорошо сделано, что все в одном месте, а тут у тебя если ошибка в декодировании, то ты все равно пытаешься добавить задачу, а это плохо, вот как у тебя получается. что две ошибки склеивается
Нужно либо делать в одной функции, либо возвращать и проверять ошибку
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.