-
Notifications
You must be signed in to change notification settings - Fork 382
Feat: Three spell effects added #2775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Knockback (for some reason it was "invisible" and unused) - Grievous Wounds - Healing Boost The healing and healing null percentages are editable in the server settings (I had trouble modifying the database, so I decided to leave it to someone more experienced). I added comments to everything possible to make it as clear as possible. Feedback is appreciated, as this is my first pull request for this project.
…ng, use with caution (works for me but with a initial bug) all damages and values of the spells are reseted by default when runs by first time
|
Hey @Kamusvalenzuela 2 - In the spell combat descriptor, add "PercentageEffect" int, remove it from the server options. 3 - The effect name seems too long "GrievousWoundsHealingReduction", and specific to some game, the effect name should just be HealingReduction and HealingBoost, in the enum and everywhere else. 4 - Okay then, add these 3 effects, but I need you to send a video showing everything working, the values being what they should be, correct calculations and so on, otherwise I or another reviewer would have to clone and run it, create items/spells/NPCs, do all the setup and it would take a lot of time, I myself don't have time, I will analyze as much as possible by code and as a last resort before approving is when I would do all this to test, so, for that reason (lack of time) I am always looking at the files superficially, so a video is good, and a description showing how to do the setup is better so we just follow a script to test if it's ok. I believe these 4 tasks will keep you busy for now. |
…hings for better usage, and now im gonna test every scenario
…ntation Added the migration to MySQL and SQLite (By GeminiAI) + small fixes
…rcentageEffect" remain) Migration modified to reflect previously requested names
…ntation Unwanted columns removed
and edited the migration files (Migration helped by Gemini AI 3.0)
…ntation Fix NPC crashes with new SpellEffects and refactor healing & knockback logic
Deleted empty spaces
The healing and healing null percentages are editable in the server settings (I had trouble modifying the database, so I decided to leave it to someone more experienced).
I added comments to everything possible to make it as clear as possible.
Feedback is appreciated, as this is my first pull request for this project.