fix: stop drag-drop from reparenting item icons #2794
Conversation
Fixes #2793 Prevent Gwen's default drop handler from reparenting the dragged icon into the hovered control, which could place the icon into the wrong slot/container. Draggable now forwards DragAndDrop_HandleDrop to its SlotItem parent, and the drag package stores the source SlotItem in Package.UserData to make slot handlers deterministic.
|
Done a lot of testing for hours and the bug of stacking skills and items in the same slot has been fixed, thank you. |
Stop restoring dragged icon visibility at the end of a successful drag-drop operation, since the item may have moved (e.g., inventory ↔ bank // inventory ↔ drop item) and the server-driven slot update will refresh the correct icon state. This fixes a 1-frame flash where the source slot icon briefly reappears before disappearing again.
|
fix: spell/item icon flicker after successful drag-drop 2026-01-01.16-37-34.mp4 |
Arufonsu
added
bug
Working as it should, I tested it for a few minutes together with some players on the test server and it didn't show any failures. |
- Ensures all item drops go through TryDropItem, restoring the safety prompt that asks which item and how many to drop. - Fixes a bug introduced with DragAndDrop_HandleDrop returning an incorrect boolean when bypassing the drop prompt, which caused undroppable items to have their icons hidden.
Signed-off-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com>
Arufonsu
force-pushed
the
fix/2793
branch
2 times, most recently
from
73da252 to
c68a947
Compare
Arufonsu
force-pushed
the
fix/2793
branch
2 times, most recently
from
c361198 to
847d551
Compare
Arufonsu
force-pushed
the
fix/2793
branch
2 times, most recently
from
c76c8e5 to
75de5e1
Compare
- Required logic update after fixes for item's icon handling. - hotkeys and bags handling for DragAndDrop_HandleDrop - (bags seriously need a big refactor): replaced direct packet store (buggy) and slider (never been coded properly) for at least, a simple and functional YesNo Prompt that stores whole item stacks from inventory. - HotbarItem case returns false (required so items don't go invisible when placing them to hotbars). - SpellItem to Hotbar case returns false (required so spells don't go invisible when placing them to hotbars). - fixes quantityLabels logic - visually functional bags and bank items when moving them around
Fixes #2793
Prevent Gwen's default drop handler from reparenting the dragged icon into the hovered control, which could place the icon into the wrong slot/container. Draggable now forwards DragAndDrop_HandleDrop to its SlotItem parent, and the drag package stores the source SlotItem in Package.UserData to make slot handlers deterministic.
2025-12-31.12-32-57.mp4