Open
Conversation
oczoske
added
the
bugfix
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 74.83% 74.76% -0.07%
==========================================
Files 69 69
Lines 8868 8936 +68
==========================================
+ Hits 6636 6681 +45
- Misses 2232 2255 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oczoske
changed the title
teutoburg
approved these changes
Apr 1, 2026
Contributor
teutoburg
left a comment
teutoburg
left a comment
There was a problem hiding this comment.
Two minor comments, otherwise go ahead 👍
Comment on lines
+104
to
+107
| #from astropy.io import fits | ||
| #fits.writeto(f"image_{obj.meta['wave_min'].value}.fits", data=image.value, overwrite=True) | ||
| #fits.writeto(f"kernel_{obj.meta['wave_min'].value}.fits", kernel, overwrite=True) | ||
| #fits.writeto(f"newimage_{obj.meta['wave_min'].value}.fits", new_image, overwrite=True) |
Contributor
There was a problem hiding this comment.
Is this a leftover from debugging? If so, maybe remove before merging.
Suggested change
| #from astropy.io import fits | |
| #fits.writeto(f"image_{obj.meta['wave_min'].value}.fits", data=image.value, overwrite=True) | |
| #fits.writeto(f"kernel_{obj.meta['wave_min'].value}.fits", kernel, overwrite=True) | |
| #fits.writeto(f"newimage_{obj.meta['wave_min'].value}.fits", new_image, overwrite=True) |
|
|
||
|
|
||
| def _cutout_kernel(image, fov_header, kernel_header=None): | ||
| logger.info("Going into _cutout_kernel") |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.info("Going into _cutout_kernel") | |
| logger.debug("Going into _cutout_kernel") |
I don't think this needs to be at info level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
scipy.signal.zoomwith interpolation usingRegularGridInterpolatorand WCS in PSF rescalingscipy.signal.convolvewithmode='same'to keep the (convolved) source centred in the output.(The "full" convolution of an array of size
nimgwith a kernel of sizenkernhas sizenimg+nkern-1. This has the same parity asnimgifnkernis odd.)Closes #879