Skip to content

fix: standarize name geofencing zone code #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorunnl merged 2 commits into from
Nov 3, 2025
Merged

fix: standarize name geofencing zone code #356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08225aa
fix: standarize name geofencing zone code
jorunnl Oct 31, 2025
4099eff
fix Key -> Code
jorunnl Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions packages/theme/src/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,8 @@ export type InteractiveColorName = keyof Theme['color']['interactive'];
export type InteractiveColors = Theme['color']['interactive'];
export type InteractiveState = keyof InteractiveColor;

// The colors can be changed, but should follow standard practice as commented:
export enum GeofencingZoneCodes {
allowed = 'Allowed', // blue
slow = 'Slow', // yellow
noParking = 'NoParking', // red
noEntry = 'NoEntry', // dark/black
}
export type GeofencingZoneKeys = keyof typeof GeofencingZoneCodes;
export type GeofencingZoneCode = 'allowed' | 'slow' | 'noParking' | 'noEntry';

export type GeofencingZoneStyle<T = ContrastColor> = {
color: T;
fillOpacity: number;
Expand All @@ -72,7 +66,7 @@ export type GeofencingZoneStyle<T = ContrastColor> = {
layerIndexWeight: number;
};
export type GeofencingZoneStyles<T = ContrastColor> = {
[GZKey in GeofencingZoneKeys]: GeofencingZoneStyle<T>;
[GZCode in GeofencingZoneCode]: GeofencingZoneStyle<T>;
};

export type ContrastColor = {
Expand Down