fix: explicitly set fontWeight for regular text #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosvik
requested review from
marius-at-atb,
mathiazom and
mortennordseth
as code owners
reidzeibel
approved these changes
Dec 8, 2025
Member
reidzeibel
left a comment
reidzeibel
left a comment
There was a problem hiding this comment.
Everything looks in order 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, 400 is always the default font weight, so we previously didn't specify a
fontWeightvalue for regular text. But since android text styles is also used for web, this caused an issue when a text type with regular weight was applied to an element with a different default weight. E.g.<Typo.h3 textType="body__m">which would result in bold text, since a<h3>element has bold text by default.part of https://github.com/AtB-AS/kundevendt/issues/20183