Skip to content

Simple support of negative index in array #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Atemo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simple support of negative index in array #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/script_commands.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,10 @@ value from another array) to get at an array value:

This will make .@arrayofnumbers[100] equal to 10.

.@arrayofnumbers[-1] = 20;

This will make .@arrayofnumbers[100] (the last index) equal to 20.

Index numbering always starts with 0 and arrays can hold over 2 billion
variables. As such, the (guaranteed) allowed values for indices are in the
range 0 ~ 2147483647.
Expand Down
6 changes: 5 additions & 1 deletion src/map/script.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6522,13 +6522,17 @@ BUILDIN_FUNC(getelementofarray)
id = reference_getid(data);

i = script_getnum(st, 3);
if (i < 0 || i >= SCRIPT_MAX_ARRAYSIZE) {
if (std::abs(i) >= SCRIPT_MAX_ARRAYSIZE) {
ShowWarning("script:getelementofarray: index out of range (%" PRId64 ")\n", i);
script_reportdata(data);
script_pushnil(st);
st->state = END;
return SCRIPT_CMD_FAILURE;// out of range
}
if (i < 0) {
struct map_session_data* sd = NULL;
i = cap_value( (script_array_highest_key(st, sd, reference_getname(data), reference_getref(data)) + i), 0, SCRIPT_MAX_ARRAYSIZE );
}

push_val2(st->stack, C_NAME, reference_uid(id, i), reference_getref(data));
return SCRIPT_CMD_SUCCESS;
Expand Down