Skip to content

Security Fix for Remote Code Execution - huntr.dev #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntr-helper wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Security Fix for Remote Code Execution - huntr.dev #1

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ab3ca8
fixed rce
Asjidkalam Sep 9, 2020
5f52a6f
updated fix
Asjidkalam Sep 10, 2020
16ad0cb
updated
Asjidkalam Sep 10, 2020
66ff704
Merge pull request #1 from Asjidkalam/master
JamieSlome Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var _ = require('underscore');
var exec = require('child_process').exec;
var exec = require('child_process').execFile;
var fse = require('fs-extra');
var path = require('path');
var Promise = require('bluebird');
Expand Down Expand Up @@ -99,8 +99,7 @@ function getTempBuildDir(packageName, version) {
function tarDir(dir) {
var archiveName = path.basename(dir) +'.orig.tar.xz';
var archivePath = path.join(path.dirname(dir), archiveName);

return exec('tar cfJ '+ archivePath +' '+ dir);
return exec('tar', ['cfJ', archivePath, dir]);
}

// Write the required files into the DEBIAN directory.
Expand All @@ -122,7 +121,7 @@ function writeDebianFiles(tempBuildDir, options) {

// Run dpkg to make the .deb file.
function dpkg(tempBuildDir) {
return exec('dpkg -b '+ tempBuildDir);
return exec('dpkg', ['-b', tempBuildDir]);
}

module.exports = makeDeb;
Expand Down