Some fixes #1
Open
Some fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Обновление библиотек Some fixes
1)Добавлено "О программе" и отправка письма оттуда 2)Убраны стили 3)Исправлены некоторые возможные утечки памяти
| .setPositiveButton(R.string.about_positive_button, new DialogInterface.OnClickListener() { | ||
| @Override | ||
| public void onClick(DialogInterface dialogInterface, int i) { | ||
| Intent intent = new Intent(Intent.ACTION_SENDTO, Uri.fromParts("mailto", "ne@napishesh.su", null)); |
There was a problem hiding this comment.
У меня вот эта строка не помещается в экран. Куда приятнее было бы видеть тут вызов метода onSendFeelbackClick().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1)Можно вращать экран
2)Есть диалог "О программе" с отсылкой сообщений
3)Возможно убраны некоторые утечки памяти
TODO:
4)Строка с музыкой/радио (запуск или в маркет) при подключении наушников
5)Проверить ProGuard и так далее
0)Поправить одну штуку в чтении/записи списка