Skip to content

Conversation

@hasiburr-qti
Copy link
Contributor

@hasiburr-qti hasiburr-qti commented Jun 26, 2025

Description

This PR adds the logic to build the docker image with the ubuntu user with UID and GID as 1000:1000 respectively, instead of creating the user with the default user and GID:UID present at the time of docker build.

This will ensure consistency in docker image builds, as the runners used in github have the same ubuntu user with 1000:1000 as UID and GID. This will help to save time during our workflows as workflows will not be requiring to build the image everytime instead build it once and store it in the registry so that the other jobs can just pull the docker image and use it, saving time and computation power of the runners.

Copy link
Contributor

@quic-viskuma quic-viskuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quic-aditrath
Copy link
Contributor

quic-aditrath commented Jun 30, 2025

  • In the commit description, the phrase "not be requiring th build" seems to have a typo—could you please correct that?
  • Also, please avoid using keyword like we in commit description as here "as the runners we use have the same".

This commit add the logic to build the docker image with the `ubuntu`
user with UID and GID as 1000:1000 respectively, instead of creating the
user with the default user and GID:UID present at the time of docker
build.

This will ensure consistency in docker image builds, as the runners
used in the github have the same `ubuntu` user with 1000:1000 as UID and GID.
This will help to save time during the workflows as the workflows will now not be
requiring to build the image everytime instead build it once and
store it in the registry so that the other jobs can just pull the docker
image and use it, saving time and computation power of the runners.

Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
@hasiburr-qti
Copy link
Contributor Author

  • In the commit description, the phrase "not be requiring th build" seems to have a typo—could you please correct that?
  • Also, please avoid using keyword like we in commit description as here "as the runners we use have the same".

Done

@quic-aditrath quic-aditrath merged commit 4a4cef5 into AudioReach:main Jun 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants