modules: Add PoplessEqualizer module #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 2, 2025 10:35
Add new PoplessEqualizer module under the "processing" folder. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
Enable posal timer, which allows the user to start a timer for a specified duration and call a callback function to send a signal once the timer expires. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
Build VCPM proxy, and add VCPM stub, which is required by VCPM proxy. APM is dependent on VCPM proxy to enable certain features, such as resource monitoring. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
Add some dependencies to modules, so that the compilation doesn't fail if those modules are built on their own. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
quic-plai
approved these changes
May 13, 2025
quic-plai
requested changes
May 13, 2025
Contributor
quic-plai
left a comment
quic-plai
left a comment
There was a problem hiding this comment.
I would say fwk: enable Linux POSAL timer
quic-plai
requested changes
May 13, 2025
Contributor
quic-plai
left a comment
quic-plai
left a comment
There was a problem hiding this comment.
Can we indicate that this change is just workaround. Eventually, we need to refactor VCPM proxy to have proxy logic move into APM?
| /** | ||
| * \file vcpm.c | ||
| * \brief | ||
| * This file contains VCPM Module Implementation |
Contributor
There was a problem hiding this comment.
This is just stub. Can we name vcpm_stub.c to be consistent? Also, remember to update the comment indicating it is stub implementation
quic-plai
approved these changes
May 13, 2025
Author
|
Closed to fix changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new PoplessEqualizer module under the "processing" folder.