Add SAL and limiter, and clean up build files #24
Conversation
| modules/processing/volume_control/capi/soft_vol/api | ||
| modules/cmn/common/internal_api | ||
| modules/processing/PoplessEqualizer/api | ||
| modules/processing/gain_control/limiter/api |
There was a problem hiding this comment.
Just curious. When gain module is introduced, why are these include lines not needed?
There was a problem hiding this comment.
This is line is for including the limiter api. I believe that now that I've added the limiter source code it is required to add the api here to build the full audioreach-engine image.
| Copyright (c) Qualcomm Innovation Center, Inc. All Rights Reserved. | ||
| SPDX-License-Identifier: BSD-3-Clause-Clear | ||
| ==============================================================================*/ | ||
| // clang-format off |
There was a problem hiding this comment.
Why do we need to have these changes?
There was a problem hiding this comment.
Just removed this change in latest update.
modules/CMakeLists.txt
Outdated
|
|
||
| #Build limiter as it is a dependency for other modules | ||
| #Can remove if not building IIR_MBDRC or SAL modules | ||
| add_subdirectory(processing/gain_control/limiter/build) |
There was a problem hiding this comment.
Shouldn't we add if CONFIG_IIR_MBDRC or CONFIG_SAL then build limiter?
There was a problem hiding this comment.
Updated, added a condition: if SAL or MBDRC is configured, then build limiter.
Adds simple accumulator limiter module, which allows multiple streams to be mixed together. Also removes limiter binary and adds limiter source code. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
Adds PROJECT_SOURCE_DIR path to build files for better readability. Also fixes some formatting issues and removes some build files that are not necessary. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
| SRCS ${pcm_cnv_sources} | ||
| INCLUDES ${pcm_cnv_includes} | ||
| H2XML_HEADERS "../../../audio/pcm_decoder/api/pcm_decoder_api.h" | ||
| H2XML_HEADERS "${PROJECT_SOURCE_DIR}/modules/audio/pcm_decoder/api/pcm_decoder_api.h" |
There was a problem hiding this comment.
Is line wrapping display problem? Can you also check other styling/indentation problem?
There was a problem hiding this comment.
I don't see any indentation issue in my view.
Add Virtualizer, shoebox, and reverb binaries and their necessary dependencies. This includes several audio util files, and a couple audio util functions that were not previously defined in C. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
Adds bass boost module to modules/processing folder, which allows you to boost the bass of an audio clip. Signed-off-by: Annemarie Porter <quic_annemari@quicinc.com>
2 participants
Add SAL and opensource limiter modules. Add project_source_dir paths to build files to clean up.