Generate processor ID element in module XML generated from H2XML parser #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-plai
approved these changes
Aug 2, 2025
quic-plai
reviewed
Aug 2, 2025
Contributor
quic-plai
left a comment
quic-plai
left a comment
There was a problem hiding this comment.
Please see inline comment
quic-plai
reviewed
Aug 2, 2025
… XML Introduces a new Kconfig option `PROC_DOMAIN` that allows developers to specify the target processor domain ID for AudioReach (ARE) modules. This value is used by the H2XML parser to embed the processor domain ID into the generated module XML, addressing the current limitation where the PROCESSORS element is missing by default. Supported domain options include: ADSP, MDSP, APPS, SDSP, CDSP, CC_DSP, GDSP_0, GDSP_1, and APPS_2. This eliminates the need for manual XML edits when targeting non-default processor (ADSP). Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Update the default configuration to set `CONFIG_PROC_DOMAIN="ADSP"` in the Linux defconfig. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Add check in CMake to ensure PROC_DOMAIN value is defined, non-empty and has a supported processor domain ID value. Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
Update the H2XML command in `spf_module_sources` to include the
`@h2xml_processors{<PROC_DOMAIN_NAME>}` annotation. This ensures that
the generated module XML includes the processor domain ID, as configured
via `CONFIG_PROC_DOMAIN`.
Signed-off-by: Aditya Rathi <quic_aditrath@quicinc.com>
quic-aditrath
force-pushed
the
h2xml_enable_proc_domain
branch
from
a2d0e6e to
a8e3d36
Compare
quic-plai
approved these changes
Oct 29, 2025
quic-plai
approved these changes
Oct 29, 2025
quic-plai
approved these changes
Oct 29, 2025
quic-plai
approved these changes
Oct 30, 2025
quic-plai
approved these changes
Oct 30, 2025
quic-plai
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.