audioreach-driver: Conditionally enable SMMU based on DT presence #39
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, SMMU support is forced to be enabled unconditionally in the probe function. This can lead to errors on platforms where the audio memory device does not have an IOMMU assigned in the device tree. Update the driver to check for the existence of the 'iommus' property in the device tree node. SMMU support is now enabled only if this property is present. Additionally, add a fallback to disable SMMU support if the SMMU SID parsing fails, ensuring the driver does not attempt to use an invalid SID configuration. Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
nandamajay
reviewed
Jan 9, 2026
| msm_audio_mem_data->smmu_enabled = false; | ||
|
|
||
| msm_audio_mem_data->smmu_enabled = smmu_enabled; | ||
| dev_err(dev, "%s: SMMU is %s\n", __func__, (!msm_audio_mem_data->smmu_enabled) ? "Disabled" : "Enabled"); |
Contributor
There was a problem hiding this comment.
can you please change it to dev_info or dev_dbg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SMMU support is forced to be enabled unconditionally in the probe function. This can lead to errors on platforms where the audio memory device does not have an IOMMU assigned in the device tree.
Update the driver to check for the existence of the 'iommus' property in the device tree node. SMMU support is now enabled only if this property is present.
Additionally, add a fallback to disable SMMU support if the SMMU SID parsing fails, ensuring the driver does not attempt to use an invalid SID configuration.