Fix incorrect user balance #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
approved these changes
Dec 16, 2025
rickyrombo
approved these changes
Dec 16, 2025
Contributor
rickyrombo
left a comment
rickyrombo
left a comment
There was a problem hiding this comment.
Awesome - this fixes Roneil?
| FROM artist_coins | ||
| LEFT JOIN artist_coin_stats stats ON artist_coins.mint = stats.mint | ||
| LEFT JOIN artist_coin_pools pools ON artist_coins.mint = pools.base_mint | ||
| LEFT JOIN artist_coin_prices acp ON acp.mint = artist_coins.mint |
Contributor
There was a problem hiding this comment.
super nit personal taste but I really don't like initialisms
| ON stats.mint = artist_coins.mint; | ||
| LEFT JOIN artist_coin_stats AS stats | ||
| ON stats.mint = artist_coins.mint | ||
| LEFT JOIN artist_coin_pools AS pools |
Contributor
There was a problem hiding this comment.
this table is effectively deprecated, I think we can leave this out. was planning to drop this table entirely at some point
Contributor
Author
Yes that's the hope! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where user balances and balance history showed different values. Updated user balances to follow same approach as balance history
Key fixes:
Now the price priority order is: