Skip to content

Nicer logs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stereosteve merged 2 commits into from
Apr 8, 2025
Merged

Nicer logs #8

stereosteve merged 2 commits into from
Apr 8, 2025

Conversation

@raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Apr 7, 2025

  1. fiberzab by default logs out latency with units appended at the end. this makes it very annoying to use in axiom/downstream. so implement our own (practically does the same thing)
  2. add "route" to the default log, so we can group by route rather than by the exact URL which may differ a lot

stereosteve
stereosteve approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@stereosteve stereosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@stereosteve stereosteve merged commit f9f85b2 into main Apr 8, 2025
2 checks passed
@stereosteve stereosteve deleted the rj-nicer-logs branch April 14, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyrombo rickyrombo Awaiting requested review from rickyrombo

1 more reviewer

@stereosteve stereosteve stereosteve approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson @stereosteve