Skip to content

[FRHOF][FRAIF] Full Book Content Upload#335

Open
tregolani wants to merge 16 commits intoAuroraLegacy:masterfrom
tregolani:FRHOF_FRAIF
Open

[FRHOF][FRAIF] Full Book Content Upload#335
tregolani wants to merge 16 commits intoAuroraLegacy:masterfrom
tregolani:FRHOF_FRAIF

Conversation

@tregolani
Copy link
Copy Markdown
Contributor

This PR contains all of the relevant player-facing options from the supplements Forgotten Realms: Heroes of Faerûn and Forgotten Realms: Adventures in Faerûn.

Copy link
Copy Markdown
Contributor

@FreshRoyal FreshRoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me so far, but I did leave some comments. I'll do a more thorough review once I'm done looking over DMG24.


<element name="Cult of the Dragon Initiate" type="Feat" source="Forgotten Realms: Heroes of Faerûn" id="ID_WOTC_FRHOF_FEAT_CULT_OF_THE_DRAGON_INITIATE">
<supports>Origin</supports>
<prerequisite>Origin Feat, Forgotten Realms Campaign</prerequisite>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't add "Origin Feat" to the prerequisites in PHB24

<description>You gain the following benefits.</description>
</sheet>
<rules>
<select type="Language" name="Language Proficiency (Cult of the Dragon Initiate)" supports="Standard||Exotic" default="ID_WOTC_PHB24_LANGUAGE_DRACONIC" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are "Rare" and "Exotic" languages used interchangeably for backwards compatibility?

Copy link
Copy Markdown
Contributor Author

@tregolani tregolani Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check on this one. I likely just copied some code from a language grant. It's possible we need to add "Standard||Rare||Exotic" instead.

EDIT: Looks like PHB24 only uses "Rare" to denote languages either originating from another plane or secret (Druidic/Thieves' Cant). It does not use the "Exotic" or "Secret" categories at all—these were exclusive to PHB14 and its supplements. From the look of it, PHB24 "Rare" is equivalent to PHB14 "Exotic + Secret"

</sheet>
<rules>
<select type="Language" name="Language Proficiency (Cult of the Dragon Initiate)" supports="Standard||Exotic" default="ID_WOTC_PHB24_LANGUAGE_DRACONIC" />
<select type="Feat Feature" name="Dragon Terror" supports="Dragon Terror" default="ID_WOTC_FRHOF_FEAT_FEATURE_CULT_OF_THE_DRAGON_INITIATE_DRAGONS_TERROR" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we usually just use "Feat Features" for selectable features?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the feat adds benefits that are "always on" and others that are limited by uses, I created a "selectable" feature with a default so it nests the benefit under the main feat item on the sheet. Therefore I can have a usage callout for the "sub-benefit" while still listing the main benefit as "always on".

I used this "sub-benefit" styling for quite a few of the subclasses and feats.

</element>

<element name="Level 3: Knightly Envoy" type="Archetype Feature" source="Forgotten Realms: Heroes of Faerûn" id="ID_WOTC_FRHOF_ARCHETYPE_FEATURE_FIGHTER_BANNERET_KNIGHTLY_ENVOY">
<requirements>!ID_INTERNAL_FRHOF_FEATURE_REPLACEMENT_FIGHTER_BANNERET_KNIGHTLY_ENVOY</requirements>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my question about ABH, are we adding replacement grants to supplement subclasses, too?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we do this for subclasses in PHB24? Are we going to treat supplement stuff differently? I'll let you guys make the call.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before 5.5e, it was just the subclasses that came with the class that would get replacement grants because of the OCFs Beast Master got in TCoE. The only exception I can think of was Divine Strike/Potent Spellcasting for Cleric subclasses. I'm personally okay with all supplement subclasses getting them now, but if that's the case, it would cause inconsistencies with older subclasses.

Copy link
Copy Markdown
Contributor

@FreshRoyal FreshRoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source information setters

<set name="abbreviation">FRAIF</set>
<set name="url">https://marketplace.dndbeyond.com/category/4714000?pid=D4714000</set>
<set name="image">https://raw.githubusercontent.com/AuroraLegacy/elements/master/supplements/forgotten-realms-adventures-in-faerun/FRAIF.png</set>
<set name="author" abbreviation="WOTC" url="http://dnd.wizards.com">Wizards of the Coast</set>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<set name="author" abbreviation="WOTC" url="http://dnd.wizards.com">Wizards of the Coast</set>
<set name="author" abbreviation="WOTC" url="http://dnd.wizards.com">Wizards of the Coast</set>
<set name="information">D&amp;D 5.5e</set>

<set name="abbreviation">FRHOF</set>
<set name="url">https://marketplace.dndbeyond.com/category/4712000?pid=D4712000</set>
<set name="image">https://raw.githubusercontent.com/AuroraLegacy/elements/master/supplements/forgotten-realms-heroes-of-faerun/FRHOF.png</set>
<set name="author" abbreviation="WOTC" url="http://dnd.wizards.com">Wizards of the Coast</set>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<set name="author" abbreviation="WOTC" url="http://dnd.wizards.com">Wizards of the Coast</set>
<set name="author" abbreviation="WOTC" url="http://dnd.wizards.com">Wizards of the Coast</set>
<set name="information">D&amp;D 5.5e</set>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants