fix: improve macOS Sequoia & Tahoe compatibility and stability#16
Open
tan9 wants to merge 5 commits intoAuroraWright:mainfrom
Open
fix: improve macOS Sequoia & Tahoe compatibility and stability#16tan9 wants to merge 5 commits intoAuroraWright:mainfrom
tan9 wants to merge 5 commits intoAuroraWright:mainfrom
Conversation
- Upgrade KeyboardShortcuts from 1.14.1 to 2.4.0 * Includes macOS 15 keyboard shortcut fixes * Improves Option key support - Migrate LaunchAtLogin from Legacy 5.0.0 to Modern 1.1.0 * Uses native SMAppService API for macOS 13+ * Removes unnecessary helper app copy script - Update minimum macOS version from 12.0 to 13.0 - Update LaunchAtLogin API usage in View.swift * Replace @ObservedObject with @State * Use LaunchAtLogin.isEnabled directly with Binding - Remove LaunchAtLogin.migrateIfNeeded() call in App.swift
Fixes issue where the app was being terminated by macOS after ~19 minutes of inactivity on macOS Sequoia. - Add activityToken property to track activity assertion - Implement startActivity() to begin activity assertion - Implement endActivity() to end activity assertion - Call startActivity() when timer starts - Call endActivity() when timer stops - Uses ProcessInfo.beginActivity with .userInitiated and .idleSystemSleepDisabled options
- Improve authorization request error handling * Use optional binding for error handling * Log authorization status on denial - Add checkAuthorizationStatus() method - Add logAuthorizationStatus() with detailed status messages - Add openSystemNotificationSettings() to guide users - Add requestAuthorizationIfNeeded() for smart authorization - Update send() method to verify authorization before sending * Check authorization status before each notification * Provide helpful error messages for different denial scenarios - Import AppKit for NSWorkspace access
- Add NSSupportsAutomaticTermination = false - Add NSSupportsSuddenTermination = false These settings prevent macOS from automatically terminating the app when it's considered inactive, which is important for a timer app that needs to run continuously in the background.
- Add .fixedSize() to StartStopDropdown to prevent compression - Replace .frame(maxWidth: .infinity) with Spacer() in HStacks * Prevents Text from taking all available space * Allows picker to maintain its ideal size - Increase default popover width from 255 to 300 * Accommodates segmented controls properly * Prevents "Stop after" label from wrapping - Update localization file with new default width Fixes issue where "Stop after" text was displaying vertically and segmented control options were compressed.
tan9
changed the title
|
Hi! I added these fixes to my fork https://github.com/ArtemYurov/TomoBar, please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves TomatoBar's compatibility and stability on macOS Sequoia (15.x) and Tahoe (26.x) by upgrading dependencies, preventing App Nap termination, and fixing UI layout issues.
Key Changes
1. Upgrade Dependencies for macOS Sequoia & Tahoe Compatibility
2. Fix Timer Termination Issue
ProcessInfo.beginActivitywith.userInitiatedand.idleSystemSleepDisabledoptions3. Improve Notification Authorization Handling
4. Prevent Automatic Termination
NSSupportsAutomaticTermination = falseNSSupportsSuddenTermination = false5. Fix UI Layout Issues
.fixedSize()to prevent segmented control compression.frame(maxWidth: .infinity)withSpacer()Testing
Tested on macOS Sequoia 15.x and Tahoe 26.x:
Breaking Changes
Migration Notes
Users on macOS 12 will need to upgrade to macOS 13 or later to use this version.
Fixes
Resolves the consistent crash after 19 minutes on macOS Sequoia & Tahoe where the system terminated the app due to App Nap.