Skip to content

Add setuptools to install_requires for pkg_resources compatibility#1

Open
bob-autoidm wants to merge 1 commit intoAutoIDM:masterfrom
bob-autoidm:fix/pkg-resources
Open

Add setuptools to install_requires for pkg_resources compatibility#1
bob-autoidm wants to merge 1 commit intoAutoIDM:masterfrom
bob-autoidm:fix/pkg-resources

Conversation

@bob-autoidm
Copy link
Copy Markdown

@bob-autoidm bob-autoidm commented Mar 20, 2026

Modern Python (3.12+) no longer bundles setuptools, and setuptools>=82 removed pkg_resources entirely. The pytz dependency (pinned at 2018.4 via singer-python) uses pkg_resources as a fallback for timezone data loading, causing 'pkg_resources not found' errors in modern environments.

Adding setuptools as an explicit dependency ensures pkg_resources remains available.

Fixes FreshDesk #945.


Note

Low Risk
Low risk dependency-only change; main impact is packaging/runtime environment compatibility and potential version conflicts with downstream tooling.

Overview
Adds setuptools to install_requires in setup.py so the package explicitly pulls in setuptools at runtime (improving compatibility in environments where it’s no longer bundled).

Written by Cursor Bugbot for commit 1b935a8. This will update automatically on new commits. Configure here.

Modern Python (3.12+) no longer bundles setuptools, and setuptools>=82
removed pkg_resources entirely. The pytz dependency (pinned at 2018.4 via
singer-python) uses pkg_resources as a fallback for timezone data loading,
causing 'pkg_resources not found' errors in modern environments.

Adding setuptools as an explicit dependency ensures pkg_resources remains
available.
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread setup.py
'PyMySQL==0.9.3',
'backoff==1.8.0',
'mysql-replication==0.22',
'setuptools',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpinned setuptools allows versions without pkg_resources

High Severity

The PR description states that setuptools>=82 removed pkg_resources entirely, yet setuptools is added here without an upper version bound. This means pip can resolve to setuptools 82+, which no longer includes pkg_resources, completely defeating the purpose of this fix. The dependency needs an upper bound (e.g., setuptools<82) to guarantee pkg_resources remains available.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant