Add setuptools to install_requires for pkg_resources compatibility#1
Open
bob-autoidm wants to merge 1 commit intoAutoIDM:masterfrom
Open
Add setuptools to install_requires for pkg_resources compatibility#1bob-autoidm wants to merge 1 commit intoAutoIDM:masterfrom
bob-autoidm wants to merge 1 commit intoAutoIDM:masterfrom
Conversation
Modern Python (3.12+) no longer bundles setuptools, and setuptools>=82 removed pkg_resources entirely. The pytz dependency (pinned at 2018.4 via singer-python) uses pkg_resources as a fallback for timezone data loading, causing 'pkg_resources not found' errors in modern environments. Adding setuptools as an explicit dependency ensures pkg_resources remains available.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| 'PyMySQL==0.9.3', | ||
| 'backoff==1.8.0', | ||
| 'mysql-replication==0.22', | ||
| 'setuptools', |
There was a problem hiding this comment.
Unpinned setuptools allows versions without pkg_resources
High Severity
The PR description states that setuptools>=82 removed pkg_resources entirely, yet setuptools is added here without an upper version bound. This means pip can resolve to setuptools 82+, which no longer includes pkg_resources, completely defeating the purpose of this fix. The dependency needs an upper bound (e.g., setuptools<82) to guarantee pkg_resources remains available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Modern Python (3.12+) no longer bundles setuptools, and setuptools>=82 removed pkg_resources entirely. The pytz dependency (pinned at 2018.4 via singer-python) uses pkg_resources as a fallback for timezone data loading, causing 'pkg_resources not found' errors in modern environments.
Adding setuptools as an explicit dependency ensures pkg_resources remains available.
Fixes FreshDesk #945.
Note
Low Risk
Low risk dependency-only change; main impact is packaging/runtime environment compatibility and potential version conflicts with downstream tooling.
Overview
Adds
setuptoolstoinstall_requiresinsetup.pyso the package explicitly pulls in setuptools at runtime (improving compatibility in environments where it’s no longer bundled).Written by Cursor Bugbot for commit 1b935a8. This will update automatically on new commits. Configure here.