fix: lint, formatting, and security warnings across validated integrations#199
Conversation
…tions - Run ruff format on canva, coda, companies-register, fathom, jira - Run ruff check --fix to remove unused imports and fix f-strings - Remove unused response assignments in canva (F841) - Add nosec B105 to test placeholder credentials (canva, coda, companies-register) - Add missing __init__.py for coda - Pin SDK version in requirements.txt for canva and coda
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56d90b5484
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The previous format pass used local ruff defaults (line-length=88). CI uses the tooling repo's ruff.toml with line-length=120. Also fix 3 E501 long lines in companies-register tests.
The added coda/__init__.py triggers the README checker which requires README.md to be modified when new files are added to an integration.
|
@sumitramanga This is a PR for your PR :-) I had to trigger tooling runs manually (https://github.com/Autohive-AI/autohive-integrations/actions/runs/23722412915) because of the GH action wasn't setup for the PR of a PR flow, but it passes now. If you're happy with the changes, you should be able to merge this into you PR, then your PR should be clean from a tooling point of view so that you can get the merge in. |
2 participants
Description 📝
Fixes CI validation warnings surfaced by #198 that are unrelated to the name changes. All changes are non-destructive (no behavioural changes).
Changes
response =assignments (fire-and-forgetawait context.fetch()calls)# nosec B105to test placeholder credentials__init__.py__init__.pyautohive-integrations-sdk~=1.0.2inrequirements.txtworkflow_dispatchtrigger withmasterfallback forbase_refNot addressed (would change behaviour)
inputs["key"]in canva/coda, unused schema params in ghost)Integration.load()warning for awsprofile:read, fathompublic_api)Closes #198 (supports)