feat(skills): add writing-unit-tests and writing-integration-tests skills#37
Merged
TheRealAgentK merged 4 commits intomasterfrom Apr 22, 2026
Merged
Conversation
…ring Covers file structure, 6 test categories (happy path, request verification, error paths, edge cases, response shape, business logic), mocking patterns, coverage expectations, and common gotchas.
Coverage —
|
| File | Stmts | Miss | Cover | Missing |
|---|---|---|---|---|
src/autohive_integrations_sdk/__init__.py |
2 | 0 | 100% | |
src/autohive_integrations_sdk/integration.py |
358 | 0 | 100% |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32ff626ab8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…utput schema cleanup - Add ActionError with cost_usd example for cost-bearing error paths - Add conversion pattern for preserving cost_usd during migration - Add step to remove 'error' property from output schemas in config.json - Add output schema cleanup to checklist Addresses feedback from Ninos.
NinosMan
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new agent skills for writing pytest tests for Autohive integrations, plus updates to the existing upgrade skill.
writing-unit-tests(mock_context + FetchResponse pattern)test_*_unit.py), single vs split files for large integrations, boilerplate headerside_effect, exceptions, DELETE 204,asyncio.sleeppatching, env varswriting-integration-tests(live_context + aiohttp pattern)test_*_integration.py), double exclusion from CI (file naming + marker)require_*skip helpers,.env.exampledocumentation@pytest.mark.destructivefor write operations, separate run commandsupgrading-sdk-v2updates (Ninos's feedback)ActionErrorwithcost_usdexample for cost-bearing error paths (e.g. billable API call fails)cost_usdduring migration"error"property from action output schemas inconfig.jsonafter migrating toActionErrorContext
Built while migrating the HubSpot integration (48 actions, 256 unit tests, 41 integration tests). Codifies the patterns that emerged from that work so future integrations get consistent test coverage.