Refactor ISSQN calculation to use TributacaoIssqn class for consistency#43
Merged
robertorp merged 3 commits intora/feat-reforma-tributariafrom Nov 6, 2025
Merged
Conversation
…base Co-authored-by: robertorp <10251705+robertorp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on previous PR
Refactor ISSQN calculation to use TributacaoIssqn class for consistency
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #42 to make ISSQN calculation in
CalculaBaseCalculoIbsCbsconsistent with how other taxes (PIS, COFINS, ICMS) are calculated.Changes
TributacaoIssqnclass - Ensures discount handling respects_tipoDescontoparameter through proper abstractionfalsetoCalcula()- Skips retention calculations (ValorRetPis, ValorRetCofins, etc.) since only ISSQN value is needed for base deductionBefore:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.