Skip to content

chore(deps): bump golang.org/x/net from 0.0.0-20211105192438-b53810dc28af to 0.38.0#43

Merged
sjinks merged 1 commit intotrunkfrom
dependabot/go_modules/golang.org/x/net-0.38.0
Apr 1, 2026
Merged

chore(deps): bump golang.org/x/net from 0.0.0-20211105192438-b53810dc28af to 0.38.0#43
sjinks merged 1 commit intotrunkfrom
dependabot/go_modules/golang.org/x/net-0.38.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Nov 19, 2025

Bumps golang.org/x/net from 0.0.0-20211105192438-b53810dc28af to 0.38.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20211105192438-b53810dc28af to 0.38.0.
- [Commits](https://github.com/golang/net/commits/v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Nov 19, 2025
@sjinks
Copy link
Copy Markdown
Member

sjinks commented Apr 1, 2026

@dependabot rebase

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 1, 2026

Looks like this PR is already up-to-date with trunk! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@sjinks
Copy link
Copy Markdown
Member

sjinks commented Apr 1, 2026

@copilot, please analyze the compatibility issues and risks associated with merging this pull request.

Copy link
Copy Markdown

Copilot AI commented Apr 1, 2026

@copilot, please analyze the compatibility issues and risks associated with merging this pull request.

Here's the compatibility and risk analysis for bumping golang.org/x/net from 0.0.0-20211105192438-b53810dc28af to 0.38.0:


Security Vulnerabilities Fixed

This update resolves multiple CVEs present in the old version:

CVE Severity Affects Description
CVE-2021-33194 High x/net/html Infinite loop via crafted ParseFragment input (DoS)
CVE-2022-27664 High x/net/http2 DoS via specially crafted HTTP/2 requests
CVE-2022-41721 High x/net/http2/h2c HTTP Request Smuggling
CVE-2022-41723 High x/net Uncontrolled resource consumption (DoS)
CVE-2023-39325 High x/net HTTP/2 Rapid Reset attack (DoS)
CVE-2023-3978 Medium x/net/html Incorrect text node rendering
CVE-2024-45338 Medium x/net/html Non-linear parsing DoS (fixed in v0.33.0)
CVE-2025-22872 Medium x/net XSS via incorrect tag interpretation
CVE-2025-22870 Low x/net HTTP proxy bypass via IPv6 zone IDs

The primary motivation for this upgrade should be the security fixes — the old pinned pseudo-version from November 2021 is missing over 4 years of security patches.


Compatibility Risks

Low risk overall. Here's why:

  1. x/net/websocket usage: The codebase uses golang.org/x/net/websocket in remote/remote.go (acting as a WebSocket server handler). This sub-package is considered effectively deprecated by the Go team but has not been removed. The API surface used (websocket.Handler, websocket.Conn) has been stable with no breaking changes between the old and new versions. The build confirms this: go build ./... succeeds cleanly.

  2. go directive bump (1.17 → 1.23.0): The go directive was updated as part of this PR. Go 1.23 introduced changes to range semantics, iterators, and timer behavior. However, since this project doesn't use those new features and the build passes, this is a non-issue.

  3. Transitive dependency updates: golang.org/x/sys (→ v0.31.0) and golang.org/x/term (→ v0.30.0) were also updated. These are backward-compatible incremental updates with no breaking API changes.

  4. go-retryablehttp and jitterbug reclassified: Moved from // indirect to direct dependencies in go.mod — this is a cosmetic/correctness fix with no functional impact.


Recommendation

Safe to merge. The upgrade is a significant security improvement with no breaking API changes. The x/net/websocket deprecation concern is a separate issue (worth tracking as future work to migrate to a maintained library like github.com/coder/websocket), but it does not block this upgrade.

Copilot AI requested a review from sjinks April 1, 2026 02:52
@sjinks
Copy link
Copy Markdown
Member

sjinks commented Apr 1, 2026

@copilot, please create a new PR that addresses the x/net/websocket deprecation.

@sjinks sjinks self-assigned this Apr 1, 2026
Copy link
Copy Markdown

Copilot AI commented Apr 1, 2026

@sjinks I've opened a new pull request, #45, to work on those changes. Once the pull request is ready, I'll request review from you.

@sjinks sjinks merged commit 25d0d8c into trunk Apr 1, 2026
2 checks passed
@sjinks sjinks deleted the dependabot/go_modules/golang.org/x/net-0.38.0 branch April 1, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants