refactor: work in progress on Expr based NominalPhrase#2295
Draft
hippietrail wants to merge 1 commit intoAutomattic:masterfrom
Draft
refactor: work in progress on Expr based NominalPhrase#2295hippietrail wants to merge 1 commit intoAutomattic:masterfrom
Expr based NominalPhrase#2295hippietrail wants to merge 1 commit intoAutomattic:masterfrom
Conversation
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 14 days. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/P
Description
The
PatternversionNominalPhrasehas some quirks and limitations and is pretty hard to work on.This PR introduces an
Exprversion ofNominalPhrasebuilt onSequenceExpr.How Has This Been Tested?
The
Pattern's unit tests all pass using theExprversion.Some unit tests that should pass but do are added to the
Patternto illustrate some of its deficiencies.Some unit tests that wouldn't work with the
Patternbut do with theExprare added.So far the
Expris only used in the linters and otherExprs. There's a few other places thePatternis still used that have to be switched over.Checklist