-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
9.0 #15728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…a setting $__.version
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Async stack traces for common function calls, remove callbacks for `execPost()`.
Co-authored-by: hasezoey <hasezoey@gmail.com>
…omattic/mongoose into vkarpov15/async-custom-hooks-statics
…s-statics BREAKING CHANGE: Async stack traces for custom methods and statics, remove `promiseOrCallback()`
for yarn v1 and maybe other package managers
Co-authored-by: hasezoey <hasezoey@gmail.com>
BREAKING CHANGE: make UUID schema type return bson UUIDs
This reverts commit ee73295.
This reverts commit 617fc9f.
This reverts commit e255560.
…er-next upgrade to pre-release of mongodb node driver 7
Co-authored-by: Hafez <a.hafez852@gmail.com>
…riteArguments in pre("deleteOne") and pre("updateOne") document hooks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Allow pre() hooks to overwrite arguments to the wrapped function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
hasezoey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me in its current state.
Co-authored-by: hasezoey <hasezoey@gmail.com>
|
|
||
| ```javascript | ||
| // Works in Mongoose 9 | ||
| await Model.updateOne({}, [{ $set: { newProp: 'test2' } }], { updatePipeline: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there currently no way to do this globally as mongoose.set('updatePipeline', true);
I can imagine this would be painful if a project is relying heavily on update-pipelines and they would need to change it in potentially hundreds of places
AbdelrahmanHafez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, otherwise LGTM. Great work! 🎉
Summary
9.0 ready to go, just a couple of outstanding chores:
Examples