fix: fine-tune code removing patterns to skip Woo Coming Soon patterns#439
Open
laurelfulford wants to merge 2 commits intotrunkfrom
Open
fix: fine-tune code removing patterns to skip Woo Coming Soon patterns#439laurelfulford wants to merge 2 commits intotrunkfrom
laurelfulford wants to merge 2 commits intotrunkfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the theme’s pattern-cleanup logic to avoid unregistering WooCommerce “Coming Soon” patterns, which are required for the Coming Soon template to render correctly on the frontend and in the Site Editor.
Changes:
- Exempts
woocommerce/coming-soon*patterns from being unregistered during REST pattern listing (restrict_patterns). - Exempts
woocommerce/coming-soon*patterns from being unregistered during lateinitcleanup (remove_registered_patterns).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The Block Theme currently has some code that removes all patterns registered outside of Newspack, to help simplify pattern selection and help focus publishers on what we've bundled.
This has had the unfortunately side-effect of obliterating WooCommerce's 'Coming Soon' page, as the pattern is not available on the front-end 😅
This PR adds a check for those patterns specifically and makes sure they don't get removed. We may want to add our own version of this page in the future, but as is, it does the trick for now.
How to test the changes in this Pull Request:
Other information: