fix(block-theme): remove MJML image-caption filter moved to newsletters plugin#442
Open
chickenn00dle wants to merge 1 commit intotrunkfrom
Open
fix(block-theme): remove MJML image-caption filter moved to newsletters plugin#442chickenn00dle wants to merge 1 commit intotrunkfrom
chickenn00dle wants to merge 1 commit intotrunkfrom
Conversation
…rs plugin The image-caption MJML component attributes filter is now applied as a default in the newsletters plugin renderer, so the duplicate in the theme is no longer needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a now-duplicated MJML image-caption component attributes filter from the block theme, based on the behavior being moved into the Newspack Newsletters plugin renderer.
Changes:
- Stops registering the
newspack_newsletters_mjml_component_attributesfilter in the theme. - Removes the theme’s
mjml_component_attributes()implementation that forcedalign=leftandpadding=0forimage-caption.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laurelfulford
approved these changes
Apr 16, 2026
Contributor
laurelfulford
left a comment
There was a problem hiding this comment.
Looks good! Caption alignment still works with this PR + Automattic/newspack-newsletters#2078 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The MJML image-caption component attributes filter (setting
align=leftandpadding=0) was duplicated identically in both the block theme and classic theme. This code has been moved into the newsletters plugin renderer as a default in Automattic/newspack-newsletters#2078, so the duplicate in this theme is no longer needed.Depends on Automattic/newspack-newsletters#2078
Addresses https://linear.app/a8c/issue/NPPD-1316
How to test the changes in this Pull Request:
Other information:
🤖 Generated with Claude Code