feat(integrations): redesign configure view#4668
Open
chickenn00dle wants to merge 7 commits intofeat/integrations-dashboard-redesignfrom
Open
feat(integrations): redesign configure view#4668chickenn00dle wants to merge 7 commits intofeat/integrations-dashboard-redesignfrom
chickenn00dle wants to merge 7 commits intofeat/integrations-dashboard-redesignfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Redesigns the Audience → Integrations “Configure” view to match the new sectioned/2-column layout, while extending the Reader Activation Sync metadata API to provide outbound fields grouped by category for the new accordion UI.
Changes:
- Add grouped outbound metadata field options in PHP (
grouped_options) alongside the existing flatoptions. - Refactor the integrations configure view into Settings / Inbound / Outbound sections, with header-level Save action and grouped outbound accordions.
- Enhance the shared Accordion component with a
defaultOpenprop to support “first group expanded” behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/wizards/audience/views/integrations/settings-section.js | Adds a wrapper class to target updated wizard spacing/styling. |
| src/wizards/audience/views/integrations/index.js | Adjusts wizard section config for the hidden configure route and dynamic header usage. |
| src/wizards/audience/views/integrations/configure-view.scss | Adds layout/styling rules for the redesigned configure view and wizard header spacing. |
| src/wizards/audience/views/integrations/configure-view.js | Implements the new 3-section configure UI, header actions, and grouped outbound accordion rendering. |
| packages/components/src/accordion/index.js | Adds defaultOpen behavior and controlled open/close handling. |
| includes/reader-activation/sync/class-metadata.php | Adds grouped outbound metadata defaults for the REST response. |
| includes/reader-activation/integrations/class-integration.php | Includes grouped_options in the outgoing metadata field REST config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Accordion: use native <details> onToggle event instead of preventDefault + manual state; remove eslint-disable comments - Metadata: respect newspack_ras_metadata_keys filter in grouped fields; collect extension-added fields in an "Additional" group; add newspack_ras_grouped_metadata_fields filter Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This one is ready for review, but depends on #4665. I'm gonna add the blocked label until that PR is approved and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Redesigns the per-integration configure view to match the Figma designs from DSGNEWS-156.
configure-view-demo.mp4
PHP:
Metadata::get_grouped_default_fields()to return outgoing metadata fields grouped by section (Identity, Registration, Engagement, etc.)grouped_optionsto the outgoing metadata field in the REST API response (backward-compatible addition alongside existingoptions)Frontend:
configure-view.jsfrom a flat single-column layout to a 2-column sectioned layout (matching the content-gates edit pattern)setHeaderDatadefaultOpenprop to the sharedAccordioncomponentCloses DSGNEWS-156.
How to test the changes in this Pull Request:
NEWSPACK_SYNC_METADATA_VERSION_1) and ensure Newspack Newsletters is configured with an ESPOther information: