fix(access-control): bump content rule suggestion limit to 100#4669
Open
fix(access-control): bump content rule suggestion limit to 100#4669
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Content Gates “specific content” taxonomy token field query to allow showing/selecting more than the REST API default of 10 terms, so editors can manage larger taxonomy-based rules.
Changes:
- Increased the REST API
per_pageparameter for taxonomy suggestion fetching from 10 to 100 in the content rule token field.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes a bug that causes the UI for managing taxonomy-based content rules to show a maximum of 10 saved tokens.
Closes NPPD-1459.
How to test the changes in this Pull Request:
define( 'NEWSPACK_CONTENT_GATES', true );defined in wp-config.php, create or edit a content gate.trunk, observe that as you add more than 10, the UI starts to drop display of some terms you added previously.trunkthe Content Rules summary also only shows a max of 10 terms.Other information: