Skip to content

feat(block-theme): move coauthors RSS function to the Newspack Plugin#2671

Merged
laurelfulford merged 1 commit intotrunkfrom
feat/move-coauthors-rss-function
Apr 16, 2026
Merged

feat(block-theme): move coauthors RSS function to the Newspack Plugin#2671
laurelfulford merged 1 commit intotrunkfrom
feat/move-coauthors-rss-function

Conversation

@laurelfulford
Copy link
Copy Markdown
Contributor

@laurelfulford laurelfulford commented Apr 4, 2026

All Submissions:

Changes proposed in this Pull Request:

This PR is a companion to Automattic/newspack-plugin#4629; they should be tested together.

Closes NPPD-1345

How to test the changes in this Pull Request:

  1. Follow the steps in feat(block-theme): move co-authors RSS feed code to the Newspack Plugin newspack-plugin#4629.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the theme-level implementation that injected Co-Authors Plus author lists into RSS/feeds, with the intent that this responsibility now lives in the Newspack Plugin.

Changes:

  • Removed the newspack_coauthors_in_rss() filter callback.
  • Removed the add_filter( 'the_author', ... ) hook that altered feed author output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread newspack-theme/functions.php
Comment thread newspack-theme/functions.php
@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 4, 2026
@laurelfulford laurelfulford marked this pull request as ready for review April 4, 2026 01:17
@laurelfulford laurelfulford requested a review from a team as a code owner April 4, 2026 01:17
@laurelfulford laurelfulford changed the title feat: move coauthors RSS function to the Newspack Plugin feat(block-theme): move coauthors RSS function to the Newspack Plugin Apr 4, 2026
Copy link
Copy Markdown
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal. One note: this should be merged simultaneously with (or after) Automattic/newspack-plugin#4629 to avoid a window where co-author RSS support is missing entirely.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 16, 2026
@laurelfulford
Copy link
Copy Markdown
Contributor Author

Thanks @adekbadek! I'll hold off merging this one 'til the Newspack Plugin one is finalized and merged 🙂

@laurelfulford
Copy link
Copy Markdown
Contributor Author

The Newspack Plugin version of this PR has been merged, so getting this one taken care of too 🙂

@laurelfulford laurelfulford merged commit 6b00cae into trunk Apr 16, 2026
17 checks passed
@laurelfulford laurelfulford deleted the feat/move-coauthors-rss-function branch April 16, 2026 22:39
@github-actions
Copy link
Copy Markdown

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-changelog [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants