fix: correct icon block, pullquote block styles, and post title width ahead of WP 7.0#2679
Open
laurelfulford wants to merge 4 commits intotrunkfrom
Open
fix: correct icon block, pullquote block styles, and post title width ahead of WP 7.0#2679laurelfulford wants to merge 4 commits intotrunkfrom
laurelfulford wants to merge 4 commits intotrunkfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Newspack theme/editor SCSS to address WordPress 7.0 visual regressions: oversized floated Icon blocks and mismatched/oversized Pullquote styling in the editor, plus a couple related Nelson/Katharine pullquote styling fixes.
Changes:
- Constrain aligned Icon block SVG sizing (editor + front-end) to prevent overflow when large.
- Adjust editor Pullquote font sizing/behavior in the base editor styles to better match front-end rendering.
- Fix Nelson/Katharine editor pullquote alignment and border/corner presentation (and Nelson front-end pullquote borders).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| newspack-theme/sass/style-editor-base.scss | Adds editor constraints for aligned Icon blocks; adjusts Pullquote font-size handling in the editor. |
| newspack-theme/sass/blocks/_blocks.scss | Ensures aligned Icon block SVGs don’t overflow on the front-end. |
| newspack-nelson/sass/style.scss | Ensures pullquote borders render (adds missing border-style). |
| newspack-nelson/sass/style-editor.scss | Centers non-aligned pullquotes in editor; left-aligns aligned pullquotes. |
| newspack-katharine/sass/style-editor.scss | Centers non-aligned pullquotes in editor; refines aligned pullquote border/corner behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes a couple display issues in WordPress 7.0:
In fixing the pullquotes I also noticed a couple minor issues in Newspack Katharine and Nelson that are fixed in this PR - these happen in WP 6.9, too.
Closes NEWS-1690 and NEWS-1687
How to test the changes in this Pull Request:
npm run build; confirm the above issues are fixed (that icons don't exceed their containers, and that the pullquote font size is a closer match when comparing the editor to the front-end).Other information: