Skip to content

fix: correct icon block, pullquote block styles, and post title width ahead of WP 7.0#2679

Open
laurelfulford wants to merge 4 commits intotrunkfrom
fix/misc-70-fixes
Open

fix: correct icon block, pullquote block styles, and post title width ahead of WP 7.0#2679
laurelfulford wants to merge 4 commits intotrunkfrom
fix/misc-70-fixes

Conversation

@laurelfulford
Copy link
Copy Markdown
Contributor

@laurelfulford laurelfulford commented Apr 13, 2026

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a couple display issues in WordPress 7.0:

  • When floated left or right, the icon block can display too wide if it's set to a large size
  • The pullquotes are too large in the editor
  • It makes sure the post titles are the correct width in the editor

In fixing the pullquotes I also noticed a couple minor issues in Newspack Katharine and Nelson that are fixed in this PR - these happen in WP 6.9, too.

Closes NEWS-1690 and NEWS-1687

How to test the changes in this Pull Request:

  1. On a test site running the latest WordPress 7.0 RC, add the following blocks to the editor:
    • Add two icon blocks and make them large (500px); align one of them left or right
    • Add three pullquote blocks; align one of them left and one of them right
  2. Publish the post and compare; note that the pullquote font size is too big in editor, and the floated icon block is wider than its 'container':
image
  1. Apply this PR and run npm run build; confirm the above issues are fixed (that icons don't exceed their containers, and that the pullquote font size is a closer match when comparing the editor to the front-end).
  2. Switch to Newspack Katharine; confirm that the non-aligned Pullquote block has the text aligned centre in the editor.
  3. Confirm that the aligned pullquote blocks just have one little top line (not a full corner).
CleanShot 2026-04-13 at 12 36 21
  1. Switch to Newspack Nelson; confirm that the non-aligned Pullquote block has the text aligned centre in the editor.
  2. Confirm that the block has a top and bottom border on the front-end:
CleanShot 2026-04-13 at 12 37 05
  1. Lastly, on a post, add both a subtitle and post title and ensure they're the same width in the editor preview (prior to this change, the post title is too narrow, it should be ~1200px wide).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from Copilot April 13, 2026 19:37
@laurelfulford laurelfulford changed the title Fix/misc 70 fixes fix: correct icon block, pullquote block styles ahead of WP 7.0 Apr 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Newspack theme/editor SCSS to address WordPress 7.0 visual regressions: oversized floated Icon blocks and mismatched/oversized Pullquote styling in the editor, plus a couple related Nelson/Katharine pullquote styling fixes.

Changes:

  • Constrain aligned Icon block SVG sizing (editor + front-end) to prevent overflow when large.
  • Adjust editor Pullquote font sizing/behavior in the base editor styles to better match front-end rendering.
  • Fix Nelson/Katharine editor pullquote alignment and border/corner presentation (and Nelson front-end pullquote borders).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
newspack-theme/sass/style-editor-base.scss Adds editor constraints for aligned Icon blocks; adjusts Pullquote font-size handling in the editor.
newspack-theme/sass/blocks/_blocks.scss Ensures aligned Icon block SVGs don’t overflow on the front-end.
newspack-nelson/sass/style.scss Ensures pullquote borders render (adds missing border-style).
newspack-nelson/sass/style-editor.scss Centers non-aligned pullquotes in editor; left-aligns aligned pullquotes.
newspack-katharine/sass/style-editor.scss Centers non-aligned pullquotes in editor; refines aligned pullquote border/corner behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread newspack-katharine/sass/style-editor.scss Outdated
@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 13, 2026
@laurelfulford laurelfulford marked this pull request as ready for review April 13, 2026 19:43
@laurelfulford laurelfulford requested a review from a team as a code owner April 13, 2026 19:43
@laurelfulford laurelfulford changed the title fix: correct icon block, pullquote block styles ahead of WP 7.0 fix: correct icon block, pullquote block styles, and post title width ahead of WP 7.0 Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The issue or pull request needs to be reviewed wp 7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants