Skip to content

Wrap each javascript into their own function to prevent strict mode from leaking to other scripts#57

Open
Tug wants to merge 4 commits intomasterfrom
fix/concat-js-strict-mode
Open

Wrap each javascript into their own function to prevent strict mode from leaking to other scripts#57
Tug wants to merge 4 commits intomasterfrom
fix/concat-js-strict-mode

Conversation

@Tug
Copy link
Copy Markdown

@Tug Tug commented Aug 21, 2020

This PR adds a prefix and suffix to all js scripts concatenated together, so that we don't end up with errors due to scripts starting with "use strict";.

Prefix:

(function(window, document, undefined) {

Suffix:

}).call(this, window, document);

@Tug Tug self-assigned this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant