Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Remove checks from WordPress iOS that now run on Danger#117

Open
mokagio wants to merge 1 commit intomasterfrom
mokagio/remove-danger-wp-ios-rules
Open

Remove checks from WordPress iOS that now run on Danger#117
mokagio wants to merge 1 commit intomasterfrom
mokagio/remove-danger-wp-ios-rules

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Nov 20, 2023

The Dangerfile and dangermattic version I referred to for these changes was from b2a5d65112d6580c29c8b7f5ab33b00c35a0759d, https://github.com/wordpress-mobile/WordPress-iOS/tree/b2a5d65112d6580c29c8b7f5ab33b00c35a0759d

Notice I didn't remove the rules to run the ios-macos.ts checks because I noticed those checks include one for the Core Data model, which I couldn't find replicated either in dangermattic or in the local WordPress iOS setup.


@iangmaia I couldn't ask you for a review directly because your user was not part of the team that can review this repo. I rectified that and you should have an invite in your inbox. This ping is to avoid having to wait to know the invitation has been accepted to ask for a review.

The `Dangerfile` and dangermattic version I referred to for these
changes was from b2a5d65112d6580c29c8b7f5ab33b00c35a0759d,
https://github.com/wordpress-mobile/WordPress-iOS/tree/b2a5d65112d6580c29c8b7f5ab33b00c35a0759d

Notice I didn't remove the rules to run the `ios-macos.ts` checks
because I noticed those checks include one for the Core Data model,
which I couldn't find replicated either in dangermattic or in the local
WordPress iOS setup.
@mokagio mokagio enabled auto-merge November 20, 2023 01:06
@iangmaia
Copy link

The Dangerfile and dangermattic version I referred to for these changes was from b2a5d65112d6580c29c8b7f5ab33b00c35a0759d, https://github.com/wordpress-mobile/WordPress-iOS/tree/b2a5d65112d6580c29c8b7f5ab33b00c35a0759d

Thanks! I was refraining for now to remove these checks already as we still need to have Danger run on label, milestone and other PR changes. I don't mind if we do it now but we need to be clear with what we'll be missing (hopefully, not for long 🙂 ).

Notice I didn't remove the rules to run the ios-macos.ts checks because I noticed those checks include one for the Core Data model, which I couldn't find replicated either in dangermattic or in the local WordPress iOS setup.

Those are implemented here: Automattic/dangermattic#9
It's the last remaining pending PR. As soon as it's merged, I'll add calls to it together with other improvements.

@iangmaia I couldn't ask you for a review directly because your user was not part of the team that can review this repo. I rectified that and you should have an invite in your inbox. This ping is to avoid having to wait to know the invitation has been accepted to ask for a review.

Thank you!

@iangmaia iangmaia self-requested a review November 20, 2023 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants