Remove checks from WordPress iOS that now run on Danger#117
Remove checks from WordPress iOS that now run on Danger#117
Conversation
The `Dangerfile` and dangermattic version I referred to for these changes was from b2a5d65112d6580c29c8b7f5ab33b00c35a0759d, https://github.com/wordpress-mobile/WordPress-iOS/tree/b2a5d65112d6580c29c8b7f5ab33b00c35a0759d Notice I didn't remove the rules to run the `ios-macos.ts` checks because I noticed those checks include one for the Core Data model, which I couldn't find replicated either in dangermattic or in the local WordPress iOS setup.
Thanks! I was refraining for now to remove these checks already as we still need to have Danger run on label, milestone and other PR changes. I don't mind if we do it now but we need to be clear with what we'll be missing (hopefully, not for long 🙂 ).
Those are implemented here: Automattic/dangermattic#9
Thank you! |
The
Dangerfileand dangermattic version I referred to for these changes was from b2a5d65112d6580c29c8b7f5ab33b00c35a0759d, https://github.com/wordpress-mobile/WordPress-iOS/tree/b2a5d65112d6580c29c8b7f5ab33b00c35a0759dNotice I didn't remove the rules to run the
ios-macos.tschecks because I noticed those checks include one for the Core Data model, which I couldn't find replicated either in dangermattic or in the local WordPress iOS setup.@iangmaia I couldn't ask you for a review directly because your user was not part of the team that can review this repo. I rectified that and you should have an invite in your inbox. This ping is to avoid having to wait to know the invitation has been accepted to ask for a review.