NewConfirmationDialog: Line up Confirm button with close button #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vip-design-system-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR applies a visual alignment fix to the NewConfirmationDialog component by adding a negative right margin to align the Confirm button with the dialog's close button.
- Adds
mr: -3to the Flex container holding the Cancel and Confirm buttons to align them with the close button positioned atright: 3
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
I dont think this is aligned? I'd defer to @donaghokeeffe |
Contributor
|
+1, maybe the issue is related to the close button alignment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before:
After:
Checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run dev.