Add docs for ContentPage, NavigationPage, TabbedPage, DrawerPage, and CommandBar#902
Open
jsuarezruiz wants to merge 9 commits intomainfrom
Open
Add docs for ContentPage, NavigationPage, TabbedPage, DrawerPage, and CommandBar#902jsuarezruiz wants to merge 9 commits intomainfrom
jsuarezruiz wants to merge 9 commits intomainfrom
Conversation
Contributor
luke-whos-here
left a comment
There was a problem hiding this comment.
Left some comments and suggestions on the relevant files. I also have two overall remarks for the PR as a whole:
- With the release of the v12 docs, the .md files are now under the
/controls/navigationpath, and the images are now under the/static/img/controlspath. I would recommend moving these to the new file structure before merging. - Some of these pages feel like they would benefit from cross-linking where other controls are mentioned, e.g., TabbedPage has an extensive example covering interaction with NavigationPage. Kind of discretionary, so feel free to add some or not as you think appropriate.
|
|
||
| When `IsKeyboardNavigationEnabled` is `true`: | ||
|
|
||
| - Horizontal tabs (Top, Bottom): left and right arrow keys switch tabs. RTL layouts reverse the direction. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Horizontal tabs (Top, Bottom): left and right arrow keys switch tabs. RTL layouts reverse the direction. | |
| - Horizontal tabs: left and right arrow keys switch tabs. RTL layouts reverse the direction. |
| </ContentPage> | ||
| ``` | ||
|
|
||
| A disabled tab is skipped during keyboard and swipe navigation. If it is currently selected when disabled, selection moves to the nearest enabled tab automatically. |
Contributor
There was a problem hiding this comment.
Not sure if it really needs a detailed explanation, but this does make me wonder how preference is decided if there are two tabs that are both the nearest. (e.g., one on the left and one on the right)
| } | ||
| ``` | ||
|
|
||
| Each `NavigationPage` maintains its own back stack independently. Switching tabs does not reset the stack. |
Contributor
There was a problem hiding this comment.
Suggested change
| Each `NavigationPage` maintains its own back stack independently. Switching tabs does not reset the stack. | |
| Each `NavigationPage` maintains its own stack independently. Switching tabs does not reset the stack. |
Contributor
luke-whos-here
left a comment
There was a problem hiding this comment.
Left some comments and suggestions on the relevant files. I also have two overall remarks for the PR as a whole:
- With the release of the v12 docs, the .md files are now under the
/controls/navigationpath, and the images are now under the/static/img/controlspath. I would recommend moving these to the new file structure before merging. - Some of these pages feel like they would benefit from cross-linking where other controls are mentioned, e.g., TabbedPage has an extensive example covering interaction with NavigationPage. Kind of discretionary, so feel free to add some or not as you think appropriate.
Member
Author
|
Thanks for the thorough review! All inline suggestions have been applied. Regarding the two overall remarks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ContentPage,NavigationPage,TabbedPage,DrawerPage,CarouselPageandCommandBar(withAppBarButton,AppBarToggleButton,AppBarSeparator)static/img/reference/controls/