Open
Conversation
Contributor
luke-whos-here
left a comment
luke-whos-here
left a comment
There was a problem hiding this comment.
A couple of minor comments on the doc itself. Some of the paths where the docs are stored are from an unused earlier version and are now redirected - sorry if it's confusing!
| }); | ||
| ``` | ||
|
|
||
| The SwipeGestureRecognizer raises a `InputElement.SwipeGestureEvent` during the swipe as the pointer moves. When the swipe ends, from the pointer being released or another gesture start, it raises a `InputElement.SwipeGestureEndedEvent`. |
Contributor
There was a problem hiding this comment.
Suggested change
| The SwipeGestureRecognizer raises a `InputElement.SwipeGestureEvent` during the swipe as the pointer moves. When the swipe ends, from the pointer being released or another gesture start, it raises a `InputElement.SwipeGestureEndedEvent`. | |
| The SwipeGestureRecognizer raises an `InputElement.SwipeGestureEvent` during the swipe as the pointer moves. When the swipe ends, from the pointer being released or another gesture starting, it raises an `InputElement.SwipeGestureEndedEvent`. |
| The SwipeGestureRecognizer raises a `InputElement.SwipeGestureEvent` during the swipe as the pointer moves. When the swipe ends, from the pointer being released or another gesture start, it raises a `InputElement.SwipeGestureEndedEvent`. | ||
|
|
||
| ## Binding events | ||
| After the SwipeGestureRecognizer has been added to your control, you need to bind them in your code behind either through an inline handler or to an event function: |
Contributor
There was a problem hiding this comment.
Suggested change
| After the SwipeGestureRecognizer has been added to your control, you need to bind them in your code behind either through an inline handler or to an event function: | |
| After the `SwipeGestureRecognizer `has been added to your control, you need to bind them in your code-behind either through an inline handler or to an event function: |
|
|
||
| You will probably use these properties most often: | ||
|
|
||
| | Property | Description | |
Contributor
There was a problem hiding this comment.
Recommend adding a third column for defaults.
Comment on lines
+122
to
+133
| ## More information | ||
|
|
||
| :::info | ||
| For the complete API documentation about this gesture recognizer, see the [SwipeGestureRecognizer API reference](/api/avalonia/input/gesturerecognizers/swipegesturerecognizer). | ||
| ::: | ||
|
|
||
| :::info | ||
| View the source code on _GitHub_ [`SwipeGestureRecognizer.cs`](https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Base/Input/GestureRecognizers/SwipeGestureRecognizer.cs) | ||
| ::: | ||
|
|
||
| ## See also | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| ## More information | |
| :::info | |
| For the complete API documentation about this gesture recognizer, see the [SwipeGestureRecognizer API reference](/api/avalonia/input/gesturerecognizers/swipegesturerecognizer). | |
| ::: | |
| :::info | |
| View the source code on _GitHub_ [`SwipeGestureRecognizer.cs`](https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Base/Input/GestureRecognizers/SwipeGestureRecognizer.cs) | |
| ::: | |
| ## See also | |
| ## See also | |
| - [API reference](/api/avalonia/input/gesturerecognizers/swipegesturerecognizer). | |
| - [Source code](https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Base/Input/GestureRecognizers/SwipeGestureRecognizer.cs) |
Contributor
There was a problem hiding this comment.
So the reference/gestures path is a leftover from an earlier draft of the v12 docs restructure. We are now redirecting all docs in this path to docs/input-interaction/gestures. We'll be fine with just a single copy of the doc in that directory.
Contributor
There was a problem hiding this comment.
This doc now redirects to docs/input-interaction/gestures as of the released version of the v12 docs. We really should retire duplicate invisible pages like this one, to avoid creating confusing situations such as this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New documentation for the
SwipeGestureRecognizercovering properties (CanHorizontallySwipe, CanVerticallySwipe, Threshold, IsMouseEnabled), SwipeDirection enum, SwipeGestureEventArgs/SwipeGestureEndedEventArgs, and usage examples.