added animation reference for the skill

[EngOmarElsayed]

No description provided.

[Copilot]

Pull request overview

This PR adds a comprehensive animation patterns reference document to the SwiftUI expert skill, covering property animations, transitions, phase-based animations, keyframe animations, and the Animatable protocol. The reference is integrated into the SKILL.md workflow for reviewing, improving, and implementing SwiftUI features.

Changes:

• Added references/animation-patterns.md with detailed animation guidance covering implicit/explicit animations, transitions, iOS 17+ phase/keyframe APIs, and best practices
• Updated SKILL.md to integrate animation pattern checks into the review, improve, and implement workflows
• Added animation checklist items and reference link to SKILL.md

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
swiftui-expert-skill/references/animation-patterns.md	New comprehensive reference covering SwiftUI animation patterns, transitions, timing curves, the Animatable protocol, phase-based animations (iOS 17+), keyframe animations (iOS 17+), best practices, and common pitfalls
swiftui-expert-skill/SKILL.md	Integrated animation-patterns.md into workflows (review/improve/implement), added Animation section to Core Guidelines, added animation checklist, and added reference link

[AvdLee]

Before continuing my review, I think it's good to add a BAD and GOOD example for all cases. This will strongly improve the impact of this skill reference file!

[AvdLee]

How about adding a wrong example here with the deprecated code example?

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

[AvdLee]

Looks good to me, I actually like the separation and it makes total sense. Much better optimized. If you could look at the Copilot feedback, that would be great! After that, you can merge.