Add SwiftUI best practices from SwiftLee articles analysis#27
Merged
Conversation
Analyzed 55+ SwiftLee articles across SwiftUI and Swift categories to extract still-relevant, non-opinionated best practices. Changes: - New accessibility-patterns.md reference (traits, grouping, @ScaledMetric, Dynamic Type) - state-management.md: @entry macro, @State with @observable ownership - performance-patterns.md: Self._logChanges() alongside _printChanges - image-optimization.md: UIImage caching behavior, NSCache pattern - list-patterns.md: Identifiable pitfalls, ContentUnavailableView, scrollContentBackground - view-structure.md: conditional modifier identity, ViewModifier/ButtonStyle, redacted, UIViewRepresentable, static member lookup - sheet-navigation-patterns.md: enum-based sheet management - SKILL.md: accessibility in decision tree, core guidelines, review checklist - README.md: SwiftLee articles attribution
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0cedc1ce79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds SwiftUI best practices extracted from 55+ SwiftLee articles, focusing on accessibility, state management, view composition, performance debugging, and image optimization. The additions are factual, non-opinionated, and align with the repository's Agent Skills format and SwiftUI-focused scope.
Changes:
- New accessibility-patterns.md reference covering Dynamic Type, VoiceOver, traits, and grouping
- Enhanced state-management.md with
@Entrymacro and @State+@observable ownership guidance - Improved performance-patterns.md with Self._logChanges() debugging helper
- Expanded view-structure.md with ViewModifier/ButtonStyle patterns, redacted views, and UIViewRepresentable essentials
- Updated sheet-navigation-patterns.md with enum-based sheet management pattern
- Enhanced list-patterns.md with ID uniqueness pitfalls, ContentUnavailableView, and custom backgrounds
- Expanded image-optimization.md with UIImage loading strategies and NSCache patterns
- Updated SKILL.md to integrate accessibility guidance across workflows
- Added SwiftLee attribution to README.md
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swiftui-expert-skill/SKILL.md | Integrated accessibility patterns into decision tree, core guidelines, and review checklist; updated _logChanges reference |
| swiftui-expert-skill/references/accessibility-patterns.md | New file covering @ScaledMetric, traits, grouping patterns, and custom controls |
| swiftui-expert-skill/references/state-management.md | Added @Entry macro pattern and critical @State+@observable ownership guidance |
| swiftui-expert-skill/references/performance-patterns.md | Added Self._logChanges() alongside _printChanges with usage guidance |
| swiftui-expert-skill/references/view-structure.md | Added conditional modifier identity pitfall, ViewModifier/ButtonStyle patterns, redacted views, UIViewRepresentable lifecycle, and static member lookup |
| swiftui-expert-skill/references/sheet-navigation-patterns.md | Added enum-based sheet management pattern with Identifiable conformance |
| swiftui-expert-skill/references/list-patterns.md | Added ID uniqueness pitfalls, ContentUnavailableView (iOS 17+), and scrollContentBackground for custom backgrounds |
| swiftui-expert-skill/references/image-optimization.md | Added UIImage(named:) vs contentsOfFile guidance and NSCache pattern for bounded memory |
| README.md | Added SwiftLee articles attribution and accessibility-patterns.md to skill structure listing |
- Replace VoiceOver testing directive with implementation-focused checklist item - Strip LLDB/Xcode-console references from _printChanges/_logChanges docs
EngOmarElsayed
approved these changes
Feb 27, 2026
Collaborator
|
Amazing work man ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analyzed 55+ SwiftLee articles across the SwiftUI and Swift categories to extract still-relevant, non-opinionated SwiftUI best practices and add them to the skill. Only content that is SwiftUI-specific and factual (not architectural opinions) was included.
Changes
references/accessibility-patterns.md-- traits, grouping,@ScaledMetric, Dynamic Type, VoiceOver patternsstate-management.md--@Entrymacro,@Statewith@Observableownershipperformance-patterns.md--Self._logChanges()alongside_printChangesimage-optimization.md--UIImage(named:)caching behavior,NSCachepatternlist-patterns.md--Identifiablepitfalls,ContentUnavailableView,.scrollContentBackgroundview-structure.md-- conditional modifier identity,ViewModifier/ButtonStyle, redacted views,UIViewRepresentable, static member lookupsheet-navigation-patterns.md-- enum-based sheet managementSKILL.md-- accessibility in decision tree, core guidelines, and review checklistREADME.md-- SwiftLee articles attributionArticles providing value (traceability)
Test plan