Cleanup/prompt enh context unification#307
Open
failerko wants to merge 15 commits intoepic/#254/prompt-pack-enh--unified-contextfrom
Open
Cleanup/prompt enh context unification#307failerko wants to merge 15 commits intoepic/#254/prompt-pack-enh--unified-contextfrom
failerko wants to merge 15 commits intoepic/#254/prompt-pack-enh--unified-contextfrom
Conversation
…nitions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nitions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nesting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Switch validator, TemplateEditor, VariablePalette, TemplatePreview, TestVariablesModal, and PromptPackEditor from the old flat variableRegistry to the new per-template-group APIs (getVariablesForTemplate, getDisplayGroupsForTemplate, getSamplesForTemplate). Also update sampleContext.test.ts to use per-template samples instead of the removed allSamples export. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…h packVariables. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ed-context' into cleanup/prompt-enh--context-unification
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the template variable system, replacing the flat VariableRegistry with a structured, per-template context mapping in templateContextMap.ts. This change enhances autocomplete, validation, and UI grouping in components like TemplateEditor and TestVariablesModal. Sample data has been reorganized to match these context groups. Feedback addresses a namespace mismatch in the validator, root detection issues for namespaced variables, optimization of helper functions within effects, and minor corrections to field definitions and typos.
Pento95
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.