Skip to content

Fix/revise android inset safe area#311

Merged
failerko merged 2 commits intomasterfrom
fix/revise-android-inset-safe-area
Apr 25, 2026
Merged

Fix/revise android inset safe area#311
failerko merged 2 commits intomasterfrom
fix/revise-android-inset-safe-area

Conversation

@failerko
Copy link
Copy Markdown
Collaborator

Closes #301

Generally (hopefully) fixes spacing out UI away from android's native UI (top bar and nav bars).
Tested on an emulated tablet, regular phone and a physical fold 7, with both 3-button and gesture navigation.

@failerko failerko force-pushed the fix/revise-android-inset-safe-area branch from 75781df to cdf9443 Compare April 19, 2026 18:41
Comment thread src-tauri/gen/android/app/tauri.properties
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a robust safe-area inset handling system for Android by bridging native window insets to CSS variables, providing a fallback where the standard env(safe-area-inset-*) is insufficient. It includes updates to the Android native bridge, global CSS definitions, and various Svelte components to ensure consistent layout across devices with notches or system bars. Additionally, the PR updates the Android version name and cleans up unused dependencies in package-lock.json. One improvement was identified in the native Android code regarding the conversion of pixel values to density-independent pixels (dp) to prevent sub-pixel gaps.

Comment thread src-tauri/gen/android/app/src/main/java/com/karelian/aventura/MainActivity.kt Outdated
…MainActivity.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@failerko failerko merged commit f57cdfb into master Apr 25, 2026
1 check passed
@failerko failerko deleted the fix/revise-android-inset-safe-area branch April 25, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tablet] App content draws behind status bar (overlaps) on tablet devices

2 participants