Skip to content

fix: enhance waitForFile function to check for specific line content … #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avicted merged 1 commit into from
Feb 13, 2026
Merged

fix: enhance waitForFile function to check for specific line content … #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions cmd/client/voice_daemon_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,25 @@ func makeExecutableFile(t *testing.T, path string, content string) {
}
}

func waitForFile(t *testing.T, path string, timeout time.Duration) string {
func waitForFile(t *testing.T, path string, timeout time.Duration, wantLine string) string {
t.Helper()
deadline := time.Now().Add(timeout)
for {
data, err := os.ReadFile(path)
if err == nil {
return string(data)
content := string(data)
if wantLine == "" || hasLine(content, wantLine) {
return content
}
}
if !errors.Is(err, os.ErrNotExist) {
t.Fatalf("read %s: %v", path, err)
}
if time.Now().After(deadline) {
t.Fatalf("timed out waiting for %s", path)
if wantLine == "" {
t.Fatalf("timed out waiting for %s", path)
}
t.Fatalf("timed out waiting for %s to contain line %q", path, wantLine)
}
time.Sleep(20 * time.Millisecond)
}
Expand Down Expand Up @@ -142,14 +148,14 @@ func TestStartVoiceDaemonLaunchesProcessAndStops(t *testing.T) {
t.Fatalf("expected voiceAutoStarting=true after start")
}

argsOut := waitForFile(t, argsPath, 2*time.Second)
argsOut := waitForFile(t, argsPath, 2*time.Second, "--meter")
for _, arg := range []string{"-server", "http://dialtone.test", "-token", "secret-token", "-ipc", "/tmp/dialtone-test.sock", "--meter"} {
if !hasLine(argsOut, arg) {
t.Fatalf("expected daemon arg %q in:\n%s", arg, argsOut)
}
}

envOut := waitForFile(t, envPath, 2*time.Second)
envOut := waitForFile(t, envPath, 2*time.Second, "DIALTONE_KEEP_ME=ok")
if strings.Contains(envOut, "XDG_ACTIVATION_TOKEN=") {
t.Fatalf("expected launcher token removed from daemon environment")
}
Expand Down
Loading