Closed
Conversation
Thanks for creating a PR for your Issue!
|
Owner
|
@Hrusikesh001 Looks Good, but I checked algorithm but now I'm getting complete basic level issues The issue: The algorithm always adds these fixed beginner keywords regardless of user skill level like search_keywords.extend(["good first issue", "beginner friendly", "easy"]) I tried by removing this also but still same problem this not working according to profile match |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
🎯 Rationale
The current UI layout places the filter button away from the "Sort" button, which creates a less intuitive experience compared to the web version. Additionally, error messages such as "Request timed out" were not handled gracefully, and the "Recommended" section displayed no helpful feedback when empty. This PR addresses these issues for a more consistent and user-friendly experience.
📝 Summary of Changes
Moved Filter button closer to the Sort button.
Aligned UI elements with the web version for consistency.
Improved error messaging for request timeouts:
Now shows "Error loading issues - Request timed out. Please try again later."
🔧 Technical Details
Minor frontend refactor to adjust button alignment.
Error handling updated in the API call response.
Added conditional rendering for the Recommended section.
No new dependencies introduced.
✅ Testing
Test Coverage
✅ Manual testing completed
✅ All existing tests pass
Test Details
Verified that the filter and sort buttons are properly aligned on all screen sizes.
Tested error handling by simulating request timeouts → correct error message displayed.
Confirmed that Recommended section now shows a fallback message when no content is available.
🔄 Breaking Changes
No breaking changes introduced.
🎨 User-Facing Changes
Frontend Changes
Filter button repositioned next to Sort button.
Improved error message display for request timeouts.
Recommended section now shows an informative empty state.
Backend/API Changes
None
📋 Checklist
✅Code follows project style guidelines
✅Self-review completed
✅No debug statements left
✅Error handling implemented appropriately
✅ Branch is up to date
🚀 Deployment Notes
No special deployment steps required.
📸 Screenshots/Demo
🙏 Reviewer Notes
Please review UI alignment changes carefully on both desktop and mobile.
Confirm error messages display consistently across API failure cases.
Verify the new placeholder text in the Recommended section is clear and user-friendly.
@AvishkarPatil Could you please review and let me know if it looks good?
Please check and merge the PR