Skip to content

feat(webview): accept third-party cookies so Twitter/FB/Imgur embeds render (#526) #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(webview): accept third-party cookies so Twitter/FB/Imgur embeds render (#526) #806

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b469b1c
feat(webview): accept third-party cookies for embeds
jim-daf Apr 25, 2026
453faa9
feat(webview): accept third-party cookies for embeds
jim-daf Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Awful.apk/src/main/java/com/ferg/awfulapp/webview/AwfulWebView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ private void init() {
webSettings.setAllowUniversalAccessFromFileURLs(true);
webSettings.setAllowFileAccess(true);
webSettings.setAllowContentAccess(true);

// Issue #526: third-party embeds (Twitter, Facebook, Imgur,
// Instagram) load their iframe content from a different origin
// and need their session cookie to render. Without this the
// embed area shows a blank box or a "log in" stub.
CookieManager.getInstance().setAcceptThirdPartyCookies(this, true);
Comment on lines +105 to +109
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CookieManager is referenced here but the file doesn't import android.webkit.CookieManager, so this won't compile as-is. Add the missing import (or fully-qualify the type).

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that third-party cookies are enabled in AwfulWebView.init(), there is a second call to setAcceptThirdPartyCookies in ThreadDisplayFragment.refreshSessionCookie(). Consider removing the other call so this setting has a single source of truth and can’t drift between usages.

Copilot uses AI. Check for mistakes.
}


Expand Down
Loading