Skip to content

feat(webview): add release() helper that detaches and destroys cleanly (#562) #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(webview): add release() helper that detaches and destroys cleanly (#562) #808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26cb67
feat(webview): add release() helper for clean teardown
jim-daf Apr 25, 2026
1cead65
feat(webview): add release() helper for clean teardown
jim-daf Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Awful.apk/src/main/java/com/ferg/awfulapp/webview/AwfulWebView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,28 @@ public void onResume() {
resumeTimers();
}


/**
* Issue #562: the renderer process leaks when a WebView is dropped
* without an explicit destroy(), and the well-known fix is to
* detach from the parent first so Chromium can release its surface.
* Callers (fragments, activities) should invoke this from their
* own onDestroy() / onDestroyView().
*/
public void release() {
if (jsInterface != null) {
removeJavascriptInterface(HANDLER_NAME_IN_JAVASCRIPT);
jsInterface = null;
}
loadUrl("about:blank");
clearHistory();
ViewGroup parent = (ViewGroup) getParent();
if (parent != null) {
parent.removeView(this);
Comment on lines +134 to +136
}
destroy();
}

/**
* Connects a handler to the JavaScript functions added to HTML for threads, posts, messages etc.
* <p>
Expand Down
Loading