Skip to content

Fix: ensure screenshots directory exists before saving #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kurom1ii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: ensure screenshots directory exists before saving #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions modules/services/Screenshot.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@ QtObject {
command: ["mkdir", "-p", root.screenshotsDir]
}

// Ensure screenshotsDir is set and the directory exists
function ensureScreenshotsDir() {
if (root.screenshotsDir === "") {
root.screenshotsDir = Quickshell.env("HOME") + "/Pictures/Screenshots"
}
ensureDirProcess.command = ["mkdir", "-p", root.screenshotsDir]
ensureDirProcess.running = true
}

// Dynamic list of freeze processes, managed via bash for simplicity?
// Or we can use a single shell script that forks grim for each monitor.
// "grim -o name1 path1 & grim -o name2 path2 & wait"
Expand Down Expand Up @@ -301,9 +310,7 @@ QtObject {
if (root.captureMode === "lens") {
root.finalPath = root.lensPath;
} else {
if (root.screenshotsDir === "") {
root.screenshotsDir = Quickshell.env("HOME") + "/Pictures/Screenshots"
}
root.ensureScreenshotsDir()
var filename = "Screenshot_" + getTimestamp() + ".png"
root.finalPath = root.screenshotsDir + "/" + filename
}
Expand Down Expand Up @@ -366,9 +373,7 @@ QtObject {
if (root.captureMode === "lens") {
root.finalPath = root.lensPath;
} else {
if (root.screenshotsDir === "") {
root.screenshotsDir = Quickshell.env("HOME") + "/Pictures/Screenshots"
}
root.ensureScreenshotsDir()
var filename = "Screenshot_" + getTimestamp() + ".png"
root.finalPath = root.screenshotsDir + "/" + filename
}
Expand Down Expand Up @@ -405,9 +410,7 @@ QtObject {
if (root.captureMode === "lens") {
root.finalPath = root.lensPath;
} else {
if (root.screenshotsDir === "") {
root.screenshotsDir = Quickshell.env("HOME") + "/Pictures/Screenshots"
}
root.ensureScreenshotsDir()
var filename = "Screenshot_" + getTimestamp() + ".png"
root.finalPath = root.screenshotsDir + "/" + filename
}
Expand Down