fix: compositor theming and keybindings not applied at runtime#147
Open
BluePhi09 wants to merge 2 commits intoAxenide:mainfrom
Open
fix: compositor theming and keybindings not applied at runtime#147BluePhi09 wants to merge 2 commits intoAxenide:mainfrom
BluePhi09 wants to merge 2 commits intoAxenide:mainfrom
Conversation
- CompositorKeybinds was removed from shell.qml in the merge, leaving it never instantiated — keybindings were never applied - CompositorConfig.applyCompositorConfigInternal() was calling CompositorTomlWriter.refresh() instead of executing the built batchCommand; updated to use the new axctl config apply command (matching GameModeService pattern, replacing the old raw-batch) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
axctl config apply expects a JSON payload, not keyword strings. The correct command for semicolon-separated keyword commands is raw-batch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e242751 to
0963756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Two regressions were introduced that caused window theming and keybindings to stop working entirely.
shell.qml—CompositorKeybindswas dropped from instantiationCompositorKeybindsis not a singleton, so it must be explicitly instantiated inshell.qml. The block was accidentally removed during the merge:Without it,
axctl config keybinds-batchwas never called and no keybindings were ever registered.CompositorConfig.qml— wrong axctl command usedapplyCompositorConfigInternal()builds a semicolon-separated keyword string (e.g.keyword general:border_size 2 ; keyword decoration:rounding 8 ; ...) and needs to send it to axctl.The merge replaced:
with a call to
CompositorTomlWriter.refresh(), which only writes the TOML file but never applies the changes to the live compositor.axctl config raw-batchis the correct command for keyword strings —axctl config applyexpects a JSON payload and rejects them with:Changes
shell.qmlCompositorKeybindsinstantiationmodules/services/CompositorConfig.qmlaxctl config raw-batchfor the keyword batch command