fix(osd/notch/shell): animation fixes, SafeLoader component, Vulkan backend detection #159
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import QtQuick | ||
|
|
||
| /** | ||
| * SafeLoader - A Loader with built-in error handling and fallback UI | ||
| * Use this instead of plain Loader for components that may fail to load | ||
| */ | ||
| Item { | ||
| id: root | ||
|
|
||
| property var sourceComponent | ||
| property string placeholderText: "Loading..." | ||
| property bool showPlaceholder: true | ||
| property color placeholderColor: "#808080" | ||
| property var fallbackItem | ||
|
|
||
| // Internal loader — not exposed as public API to prevent callers from | ||
| // bypassing root.sourceComponent and writing to it directly. | ||
| Loader { | ||
| id: internalLoader | ||
| anchors.fill: parent | ||
| sourceComponent: root.sourceComponent | ||
| asynchronous: true | ||
|
|
||
| onStatusChanged: { | ||
| if (internalLoader.status === Loader.Error) { | ||
| console.error("[SafeLoader] Failed to load component:", internalLoader.errorString); | ||
| root.handleError(internalLoader.errorString); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| signal loadError(string errorString) | ||
|
|
||
| function handleError(errorString) { | ||
| root.loadError(errorString); | ||
| } | ||
|
|
||
| // Read-only state properties | ||
| readonly property bool isLoading: internalLoader.status === Loader.Loading | ||
| readonly property bool hasError: internalLoader.status === Loader.Error | ||
| readonly property bool isReady: internalLoader.status === Loader.Ready | ||
|
|
||
| // Fallback content when loading or error | ||
| StyledRect { | ||
| id: placeholder | ||
| anchors.fill: parent | ||
| visible: root.showPlaceholder && (root.isLoading || root.hasError) && !root.fallbackItem | ||
| color: root.hasError ? "#20000000" : "transparent" | ||
|
|
||
| Text { | ||
| anchors.centerIn: parent | ||
| text: root.hasError ? "Failed to load" : root.placeholderText | ||
| color: root.placeholderColor | ||
| font.pixelSize: 14 | ||
| } | ||
| } | ||
|
|
||
| // Container for a caller-supplied fallback item; shown on error only. | ||
| Item { | ||
| id: fallbackContainer | ||
| anchors.fill: parent | ||
| visible: root.fallbackItem !== null && root.hasError | ||
| z: 10 | ||
| } | ||
|
|
||
| // Reparent a caller-supplied item into the fallback container so it | ||
| // becomes visible when the load fails. | ||
| function setFallback(item) { | ||
| root.fallbackItem = item; | ||
| item.parent = fallbackContainer; | ||
| } | ||
|
|
||
| // Retry loading by null-cycling sourceComponent (standard QML pattern). | ||
| function retry() { | ||
| var current = root.sourceComponent; | ||
| internalLoader.sourceComponent = null; | ||
| internalLoader.sourceComponent = current; | ||
|
Comment on lines
+76
to
+77
There was a problem hiding this comment.
Useful? React with 👍 / 👎. |
||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StyledRectrequires itsvariantproperty, but this placeholder instance never sets one. As soon asSafeLoaderis instantiated, QML will raise a required-property initialization error for this child and the fallback/loading UI cannot be created reliably. Assign a valid variant (for example"common"or"popup") on thisStyledRectinstance.Useful? React with 👍 / 👎.